Skip to content

Fix 'since' version for Dota2 provider#1473

Merged
kingthorin merged 1 commit intodatafaker-net:mainfrom
valfirst:patch-7
Dec 31, 2024
Merged

Fix 'since' version for Dota2 provider#1473
kingthorin merged 1 commit intodatafaker-net:mainfrom
valfirst:patch-7

Conversation

@valfirst
Copy link
Copy Markdown
Contributor

Commit for reference: 26e75e3

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Dec 30, 2024

PR Summary

  • Updated Dota2 Provider Version in Documentation
    The version number of the Dota2 provider used in our system has been updated in our project documentation. It's been changed from an old version, 2.3.1, to a more recent one, 2.4.0. This indicates the use of new features or improvements in our system that comes with the newly adopted version.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.29%. Comparing base (8efdd7e) to head (187da05).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1473      +/-   ##
============================================
- Coverage     92.35%   92.29%   -0.07%     
+ Complexity     3252     3250       -2     
============================================
  Files           324      324              
  Lines          6387     6387              
  Branches        623      623              
============================================
- Hits           5899     5895       -4     
- Misses          339      341       +2     
- Partials        149      151       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valfirst valfirst changed the title [docs] Fix 'since' version for Dota2 provider Fix 'since' version for Dota2 provider Dec 30, 2024
@kingthorin
Copy link
Copy Markdown
Collaborator

Doesn't this actually suggest 2.4.2? (Since it seems to show between 2.4.1 and 2.4.2)
image

@valfirst
Copy link
Copy Markdown
Contributor Author

@kingthorin 'since' define the first version the provider is available from
Screenshot 2024-12-31 at 12 57 23

@kingthorin
Copy link
Copy Markdown
Collaborator

Thanks!

@kingthorin kingthorin merged commit 1da4a8f into datafaker-net:main Dec 31, 2024
@valfirst valfirst deleted the patch-7 branch December 31, 2024 11:24
@asolntsev asolntsev added this to the 2.4.3 milestone Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants