Respect arg types while looking for method for expressions#1465
Merged
snuyanzin merged 3 commits intodatafaker-net:mainfrom Dec 14, 2024
Merged
Respect arg types while looking for method for expressions#1465snuyanzin merged 3 commits intodatafaker-net:mainfrom
snuyanzin merged 3 commits intodatafaker-net:mainfrom
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1465 +/- ##
============================================
- Coverage 92.32% 92.30% -0.03%
- Complexity 3234 3245 +11
============================================
Files 324 324
Lines 6347 6377 +30
Branches 610 622 +12
============================================
+ Hits 5860 5886 +26
Misses 343 343
- Partials 144 148 +4 ☔ View full report in Codecov by Sentry. |
snuyanzin
force-pushed
the
1463
branch
2 times, most recently
from
9b6aecd to
12b834e
Compare
asolntsev
approved these changes
Dec 13, 2024
| assertThat(faker.expression("#{templatify '????','?','1','2','q','r'}")).matches("([12qr]){4}"); | ||
| assertThat(faker.expression("#{Name.first_name} #{Name.first_name} #{Name.last_name}")).matches("[a-zA-Z']+ [a-zA-Z']+ [a-zA-Z']+"); | ||
| assertThat(faker.expression("#{number.number_between '1','10'}")).matches("[1-9](\\.[0-9]+)?"); | ||
| assertThat(faker.expression("#{number.number_between '1','10'}")).matches("[1-9]([0-9]+)?"); |
Collaborator
There was a problem hiding this comment.
I think this regex can be simplified: [1-9]\\d* @snuyanzin
valfirst
approved these changes
Dec 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix #1463