Skip to content

Documentation: Add missing build() part to example#1462

Merged
asolntsev merged 1 commit intodatafaker-net:mainfrom
mythsunwind:patch-1
Dec 9, 2024
Merged

Documentation: Add missing build() part to example#1462
asolntsev merged 1 commit intodatafaker-net:mainfrom
mythsunwind:patch-1

Conversation

@mythsunwind
Copy link
Copy Markdown
Contributor

The Java example was missing the execution of the method build() at the end of using the TextSymbolsBuilder.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Dec 9, 2024

PR Summary

  • Syntax correction in password generation code
    The current change involves a fix in the password generation code. Previously, there was a syntax error because of a missing .build() method call. This change will ensure the password generation process works as intended, improving the overall functionality and security of our system.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.39%. Comparing base (37241c2) to head (6801760).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1462      +/-   ##
============================================
+ Coverage     92.27%   92.39%   +0.11%     
- Complexity     3232     3236       +4     
============================================
  Files           324      324              
  Lines          6347     6347              
  Branches        610      610              
============================================
+ Hits           5857     5864       +7     
+ Misses          344      341       -3     
+ Partials        146      142       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asolntsev asolntsev added this to the 2.4.3 milestone Dec 9, 2024
@asolntsev asolntsev added bug Something isn't working documentation Improvements or additions to documentation labels Dec 9, 2024
@asolntsev asolntsev merged commit abdecbc into datafaker-net:main Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants