Skip to content

Add French id number generator#1446

Merged
kingthorin merged 2 commits intodatafaker-net:mainfrom
cbxp:feature/add_french_idnumber
Nov 19, 2024
Merged

Add French id number generator#1446
kingthorin merged 2 commits intodatafaker-net:mainfrom
cbxp:feature/add_french_idnumber

Conversation

@cbxp
Copy link
Copy Markdown
Contributor

@cbxp cbxp commented Nov 19, 2024

  • Add a French id number generator and unit tests.
  • Extract id number patterns

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Nov 19, 2024

PR Summary

  • Introduction of French ID Number Generation
    A new capability has been added to the program that allows creation of ID numbers for French citizens and residents. This particularly is managed by a newly introduced class named FrenchIdNumber.

  • Integration of French ID Number Generation into the Service
    The newly created class FrenchIdNumber has been incorporated into the service configuration file, making it a part of the ID number generation service.

  • Establishment of ID Number Patterns
    In efforts to define formats of various ID numbers, a new class IdNumberPatterns has been added. This includes the rules for the pattern of French ID numbers.

  • Introduction of Tests for French ID Number Validation
    A new test class named FrenchIdNumberTest has been created to assure the correct operation of the FrenchIdNumber class. This includes tests for both valid and invalid French ID numbers and checks for accurate calculations.

  • Updates to Previously Existing Tests
    The existing class IdNumberTest went through modifications which now enables it to include validation tests for French ID numbers as part of the broader ID formats. This ensures a comprehensive testing process that considers all types of ID numbers.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.20%. Comparing base (cda7fb2) to head (410500b).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1446      +/-   ##
============================================
- Coverage     92.23%   92.20%   -0.03%     
- Complexity     3165     3175      +10     
============================================
  Files           320      321       +1     
  Lines          6183     6198      +15     
  Branches        593      593              
============================================
+ Hits           5703     5715      +12     
- Misses          338      340       +2     
- Partials        142      143       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@asolntsev asolntsev added this to the 2.4.3 milestone Nov 19, 2024
@asolntsev asolntsev self-assigned this Nov 19, 2024
@asolntsev asolntsev added the enhancement New feature or request label Nov 19, 2024
@kingthorin kingthorin merged commit eb0fd30 into datafaker-net:main Nov 19, 2024
@cbxp cbxp deleted the feature/add_french_idnumber branch November 20, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants