feature: add movie name to movie provider#1442
Merged
bodiam merged 2 commits intodatafaker-net:mainfrom Nov 18, 2024
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1442 +/- ##
============================================
- Coverage 92.26% 92.25% -0.02%
Complexity 3166 3166
============================================
Files 320 320
Lines 6182 6183 +1
Branches 593 593
============================================
Hits 5704 5704
Misses 338 338
- Partials 140 141 +1 ☔ View full report in Codecov by Sentry. |
asolntsev
approved these changes
Nov 18, 2024
Contributor
|
Nice one, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the below method to the existing movie provider:
new Faker().movie().name();Functionality has been validated and tested locally.