Skip to content

Added input validation to prevent mistakes in version number.#1406

Merged
bodiam merged 1 commit intomainfrom
input-validation-for-release
Oct 26, 2024
Merged

Added input validation to prevent mistakes in version number.#1406
bodiam merged 1 commit intomainfrom
input-validation-for-release

Conversation

@bodiam
Copy link
Copy Markdown
Contributor

@bodiam bodiam commented Oct 26, 2024

No description provided.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Oct 26, 2024

PR Summary

  • Improved Code Clarity
    The input parameter's name was updated from releaseversion to release_version for more straightforward comprehension.
  • Enhanced Validation Implementation
    A new validation step ensures the release_version adheres to the semantic versioning format (MAJOR.MINOR.PATCH), guaranteeing maximum data integrity.
  • Refined Code Consistency
    Issues of inconsistency were addressed by standardizing myToken variable to mytoken in all instances, boosting the overall code coherence.
  • Updated Properties
    The properties tag_name and release_name within the GitHub Release action now utilize release_version, which replaces the old releaseversion. This change simplifies property mapping and increases the readability of the code.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.26%. Comparing base (6c10e43) to head (51cc5eb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1406      +/-   ##
============================================
+ Coverage     92.18%   92.26%   +0.08%     
- Complexity     3151     3154       +3     
============================================
  Files           319      319              
  Lines          6152     6152              
  Branches        593      593              
============================================
+ Hits           5671     5676       +5     
+ Misses          337      335       -2     
+ Partials        144      141       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bodiam bodiam merged commit e44f256 into main Oct 26, 2024
@bodiam bodiam deleted the input-validation-for-release branch October 26, 2024 06:51
Comment on lines +65 to +66
tag_name: ${{ github.event.inputs.release_version }}
release_name: ${{ github.event.inputs.release_version }}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this where you do want the v?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants