fix generate sql will be truncate when quote char in word#1402
Merged
bodiam merged 4 commits intodatafaker-net:mainfrom Oct 26, 2024
Merged
fix generate sql will be truncate when quote char in word#1402bodiam merged 4 commits intodatafaker-net:mainfrom
bodiam merged 4 commits intodatafaker-net:mainfrom
Conversation
PR Summary
|
asolntsev
previously approved these changes
Oct 24, 2024
asolntsev
reviewed
Oct 24, 2024
Collaborator
asolntsev
left a comment
There was a problem hiding this comment.
@shanjuren Could you please add a test? Probably in SqlTest.java
kingthorin
reviewed
Oct 24, 2024
src/main/java/net/datafaker/transformations/sql/SqlTransformer.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1402 +/- ##
============================================
+ Coverage 92.19% 92.30% +0.11%
- Complexity 3151 3153 +2
============================================
Files 319 319
Lines 6152 6149 -3
Branches 593 591 -2
============================================
+ Hits 5672 5676 +4
+ Misses 336 332 -4
+ Partials 144 141 -3 ☔ View full report in Codecov by Sentry. |
Contributor
Author
OK,i will try do it |
Contributor
Author
|
is done |
kingthorin
reviewed
Oct 25, 2024
src/main/java/net/datafaker/transformations/sql/SqlTransformer.java
Outdated
Show resolved
Hide resolved
bodiam
reviewed
Oct 26, 2024
src/main/java/net/datafaker/transformations/sql/SqlTransformer.java
Outdated
Show resolved
Hide resolved
Contributor
|
I fixed up the PR, I'll merge it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some thesaurus`s word will be truncate when I use datafaker to generate SQL, like Address,Book... That reason is when SqlTransformer calling the handledObjectToString method will be one by one add char to new Object ,but if miss quote char will be stop.