Skip to content

add missing @Override annotations#1397

Merged
kingthorin merged 1 commit intomainfrom
refactor/add-missing-override-annotations
Oct 21, 2024
Merged

add missing @Override annotations#1397
kingthorin merged 1 commit intomainfrom
refactor/add-missing-override-annotations

Conversation

@asolntsev
Copy link
Copy Markdown
Collaborator

No description provided.

@asolntsev asolntsev self-assigned this Oct 21, 2024
@asolntsev asolntsev added the enhancement New feature or request label Oct 21, 2024
@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Oct 21, 2024

PR Summary

  • Override Annotations Added
    The addition of @Override annotations to various methods in BaseFaker.java signifies that these functions replace the ones in a previous class or interface. This enhances the readability of the code by providing insights into its hierarchical relationships.

  • Enhanced String Generation Capabilities
    Methods such as numerify, letterify, bothify, regexify, examplify, templatify, csv, and json have been implemented in BaseFaker.java. These functionalities allow for a more diverse and flexible creation of strings, increasing the overall versatility of data formatting and manipulation.

  • Improved Collection Class Functionality
    Methods get() and build() have been implemented in FakeCollection.java. These upgrades ensure that the collection class operates correctly, thereby improving reliability and efficiency when manipulating collections of data.

  • Stream Generation Enhanced
    The new get() and isInfinite() methods implemented in FakeStream.java are designed to bolster stream generation capabilities. This will ultimately lead to improved data flow operations.

  • Customized JSON Formatting
    A new getElementSeparator() method was added in JsonTransformer.java, which allows for the customization of how JSON elements are separated. This provides greater flexibility when working with JSON formatted data.

  • Test Classes Updated
    Test classes have been updated, specifically AbstractFakerTest.java and HebrewFoodTest.java, to include @Override annotations for the getFaker() method. This ensures that the correct version of the faker instances is being utilized during tests, thus increasing the accuracy of testing results.

Copy link
Copy Markdown
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI passes (excluding codecov 😔)

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (17084c5) to head (848dfe7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1397      +/-   ##
============================================
+ Coverage     92.16%   92.19%   +0.03%     
- Complexity     3150     3151       +1     
============================================
  Files           319      319              
  Lines          6152     6152              
  Branches        593      593              
============================================
+ Hits           5670     5672       +2     
+ Misses          337      336       -1     
+ Partials        145      144       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kingthorin kingthorin merged commit 24f2e7a into main Oct 21, 2024
@kingthorin kingthorin deleted the refactor/add-missing-override-annotations branch October 21, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants