Skip to content

Turkish fields refactored#1389

Merged
kingthorin merged 3 commits intodatafaker-net:mainfrom
senocak:main
Oct 18, 2024
Merged

Turkish fields refactored#1389
kingthorin merged 3 commits intodatafaker-net:mainfrom
senocak:main

Conversation

@senocak
Copy link
Copy Markdown

@senocak senocak commented Oct 17, 2024

No description provided.

Copy link
Copy Markdown
Collaborator

@asolntsev asolntsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@senocak All good, but why last name has disappeared?

I cannot find these last names anymore:

  last_name: [Şen, Kandemir, Çevik, Erkuran, Tüten, Öztürk, Yüzbaşıoğlu, Vural, Yücel, Sönmez, Ertekin, Dede, Uyanık, Aslan, Akbulut, Orhon, Uz, Yavuz, Erdem, Kulaç, Kaya, Selvi, Akpınar, Abacıoğlu, Çay, Işık, Özer, Tahtacı, Büyükcam, Kulaksız, Aksel, Eroğlu, Karakum, Dal, Öcal, Ayhan, Yarbil, Canacankatan, Gümüşay, Murt, Halhallı, Uluöz, Şeyhanlı, Çalışkantürk, Yılmaz, Saraçoğlu, Sezer, Demir, Kayayurt, Sürüm, Yavaşi, Turgut, Tanrıkulu, Barbaros, Aldinç, Tekin, Gülşan, Küfeciler, Almacıoğlu, Çildir, Türkdoğan, Öner, Şeliman, Yaman, Atik, Giray, Yalçınkaya, Kılıç, Şentürk, Karabağ, Değirmenci, Boduroğlu, Yıldız, Güler, Eraslan, Üzer, Pişirgen, Adanır, Koç, Korkmaz, Yenidoğan, Aydoğan, Acarbulut, Erge, Erdoğan, Öğüt, Kuşku, Pektaş, Kayacan, Gülen, Akküçük, Candan, Temel, Yenigün, Yıldırım]

@senocak senocak requested a review from asolntsev October 18, 2024 07:01
@senocak
Copy link
Copy Markdown
Author

senocak commented Oct 18, 2024

@senocak All good, but why last name has disappeared?

I cannot find these last names anymore:

  last_name: [Şen, Kandemir, Çevik, Erkuran, Tüten, Öztürk, Yüzbaşıoğlu, Vural, Yücel, Sönmez, Ertekin, Dede, Uyanık, Aslan, Akbulut, Orhon, Uz, Yavuz, Erdem, Kulaç, Kaya, Selvi, Akpınar, Abacıoğlu, Çay, Işık, Özer, Tahtacı, Büyükcam, Kulaksız, Aksel, Eroğlu, Karakum, Dal, Öcal, Ayhan, Yarbil, Canacankatan, Gümüşay, Murt, Halhallı, Uluöz, Şeyhanlı, Çalışkantürk, Yılmaz, Saraçoğlu, Sezer, Demir, Kayayurt, Sürüm, Yavaşi, Turgut, Tanrıkulu, Barbaros, Aldinç, Tekin, Gülşan, Küfeciler, Almacıoğlu, Çildir, Türkdoğan, Öner, Şeliman, Yaman, Atik, Giray, Yalçınkaya, Kılıç, Şentürk, Karabağ, Değirmenci, Boduroğlu, Yıldız, Güler, Eraslan, Üzer, Pişirgen, Adanır, Koç, Korkmaz, Yenidoğan, Aydoğan, Acarbulut, Erge, Erdoğan, Öğüt, Kuşku, Pektaş, Kayacan, Gülen, Akküçük, Candan, Temel, Yenigün, Yıldırım]

Yes, you are right. I accidentally deleted it and put them back.

@senocak senocak requested a review from kingthorin October 18, 2024 20:23
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.15%. Comparing base (0e1e60a) to head (287654f).
Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1389      +/-   ##
============================================
- Coverage     92.22%   92.15%   -0.07%     
+ Complexity     3147     3145       -2     
============================================
  Files           319      319              
  Lines          6144     6145       +1     
  Branches        592      592              
============================================
- Hits           5666     5663       -3     
- Misses          335      337       +2     
- Partials        143      145       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kingthorin kingthorin merged commit 12bdd2a into datafaker-net:main Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants