#1306 fix non-thread-safe usages of CopyOnWriteMap#1381
Merged
Conversation
Instead of two-three separate calls like `containsKey`, `get` and `put`, now we use a single `computeIfAbsent`. P.S. I would like to also deny method `CopyOnWriteMap.put()`, but it's still used in one place (that was harder to refactor).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1381 +/- ##
============================================
- Coverage 92.40% 92.31% -0.10%
- Complexity 3148 3150 +2
============================================
Files 319 319
Lines 6178 6144 -34
Branches 604 592 -12
============================================
- Hits 5709 5672 -37
- Misses 325 329 +4
+ Partials 144 143 -1 ☔ View full report in Codecov by Sentry. |
kingthorin
approved these changes
Oct 16, 2024
Collaborator
kingthorin
left a comment
kingthorin
left a comment
There was a problem hiding this comment.
This looks good to me, thanks for digging into the problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of two-three separate calls like
containsKey,getandput, now we use a singlecomputeIfAbsent.P.S. I would like to also deny method
CopyOnWriteMap.put(), but it's still used in one place (that was harder to refactor).