Skip to content

Fix for K-pop artist lists: H.O.T., Fin.K.L, Sunmi, Stray Kids#1375

Merged
kingthorin merged 2 commits intodatafaker-net:mainfrom
badoken:main
Oct 12, 2024
Merged

Fix for K-pop artist lists: H.O.T., Fin.K.L, Sunmi, Stray Kids#1375
kingthorin merged 2 commits intodatafaker-net:mainfrom
badoken:main

Conversation

@badoken
Copy link
Copy Markdown
Contributor

@badoken badoken commented Oct 12, 2024

H.O.T., Fin.K.L - were missed in the generations list
Sunmi, Stray Kids - were missed in all the lists

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Oct 12, 2024

PR Summary

  • Expansion of K-pop Groups
    The list of K-pop groups has been broadened to cover more bands enhancing the comprehensiveness of the collection. Here's a small breakdown:
    - "H.O.T." and "Fin.K.L" now belongs under the category of boy_groups.
    - "Sunmi" and "Stray Kids" made their appearance in both the boy_groups and the solo sections.

This update brings more variety to our K-pop representation, which can attract a wider audience and increase user engagement.

Copy link
Copy Markdown
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.42%. Comparing base (330b2b6) to head (87868fe).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1375      +/-   ##
============================================
+ Coverage     92.32%   92.42%   +0.09%     
- Complexity     3146     3148       +2     
============================================
  Files           319      319              
  Lines          6178     6178              
  Branches        604      604              
============================================
+ Hits           5704     5710       +6     
+ Misses          330      324       -6     
  Partials        144      144              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kingthorin kingthorin merged commit 6df5626 into datafaker-net:main Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants