Skip to content

feat: add lint CI#469

Merged
mumoshu merged 4 commits into
databus23:masterfrom
yxxhero:feat-add-lint-ci
Jun 10, 2023
Merged

feat: add lint CI#469
mumoshu merged 4 commits into
databus23:masterfrom
yxxhero:feat-add-lint-ci

Conversation

@yxxhero

@yxxhero yxxhero commented Jun 8, 2023

Copy link
Copy Markdown
Collaborator

feat: add lint CI

yxxhero added 3 commits June 8, 2023 14:17
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
@yxxhero

yxxhero commented Jun 8, 2023

Copy link
Copy Markdown
Collaborator Author

/cc @mumoshu please approve.

Signed-off-by: yxxhero <[email protected]>
@yxxhero

yxxhero commented Jun 8, 2023

Copy link
Copy Markdown
Collaborator Author

@mumoshu all is ok.

@yxxhero

yxxhero commented Jun 9, 2023

Copy link
Copy Markdown
Collaborator Author

/cc @databus23 @mumoshu

@mumoshu mumoshu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution @yxxhero!

@mumoshu mumoshu merged commit 95b1ea0 into databus23:master Jun 10, 2023
hexcsl pushed a commit to hexcsl/helm-diff that referenced this pull request Jul 3, 2023
* feat: add lint CI

Signed-off-by: yxxhero <[email protected]>

* fix lint errors

Signed-off-by: yxxhero <[email protected]>

* fix more lint error

Signed-off-by: yxxhero <[email protected]>

* fix more lint errors

Signed-off-by: yxxhero <[email protected]>

---------

Signed-off-by: yxxhero <[email protected]>
hexcsl pushed a commit to hexcsl/helm-diff that referenced this pull request Jul 3, 2023
* feat: add lint CI

Signed-off-by: yxxhero <[email protected]>

* fix lint errors

Signed-off-by: yxxhero <[email protected]>

* fix more lint error

Signed-off-by: yxxhero <[email protected]>

* fix more lint errors

Signed-off-by: yxxhero <[email protected]>

---------

Signed-off-by: yxxhero <[email protected]>
@yxxhero yxxhero deleted the feat-add-lint-ci branch August 5, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants