Skip to content

Enforcing invalid-name pylint rule#957

Merged
nfx merged 3 commits intomainfrom
pylint/invalid-name
Feb 19, 2024
Merged

Enforcing invalid-name pylint rule#957
nfx merged 3 commits intomainfrom
pylint/invalid-name

Conversation

@nfx
Copy link
Copy Markdown
Collaborator

@nfx nfx commented Feb 19, 2024

No description provided.

@nfx nfx requested review from a team and qziyuan February 19, 2024 18:39
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (f68686c) 87.49% compared to head (2a7b659) 87.49%.

Files Patch % Lines
src/databricks/labs/ucx/hive_metastore/mapping.py 0.00% 6 Missing and 4 partials ⚠️
src/databricks/labs/ucx/workspace_access/groups.py 92.72% 1 Missing and 3 partials ⚠️
...tabricks/labs/ucx/workspace_access/verification.py 50.00% 4 Missing ⚠️
...rc/databricks/labs/ucx/workspace_access/generic.py 70.00% 0 Missing and 3 partials ⚠️
src/databricks/labs/ucx/workspace_access/scim.py 25.00% 1 Missing and 2 partials ⚠️
src/databricks/labs/ucx/assessment/jobs.py 88.88% 0 Missing and 1 partial ⚠️
src/databricks/labs/ucx/cli.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #957   +/-   ##
=======================================
  Coverage   87.49%   87.49%           
=======================================
  Files          44       44           
  Lines        5319     5319           
  Branches      949      949           
=======================================
  Hits         4654     4654           
  Misses        450      450           
  Partials      215      215           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfx nfx merged commit c8c6037 into main Feb 19, 2024
@nfx nfx deleted the pylint/invalid-name branch February 19, 2024 19:02
nfx added a commit that referenced this pull request Feb 21, 2024
* Added secret detection logic to Azure service principal crawler ([#950](#950)).
* Create storage credentials based on instance profiles and existing roles ([#869](#869)).
* Enforced `protected-access` pylint rule ([#956](#956)).
* Enforced `pylint` on unit and integration test code ([#953](#953)).
* Enforcing `invalid-name` pylint rule ([#957](#957)).
* Fixed AzureResourcePermissions.load to call Installation.load ([#962](#962)).
* Fixed installer script to reuse an existing UCX Cluster policy if present ([#964](#964)).
* More `pylint` tuning ([#958](#958)).
* Refactor `workspace_client_mock` to have combine fixtures stored in separate JSON files ([#955](#955)).

Dependency updates:

 * Updated databricks-sdk requirement from ~=0.19.0 to ~=0.20.0 ([#961](#961)).
@nfx nfx mentioned this pull request Feb 21, 2024
nfx added a commit that referenced this pull request Feb 21, 2024
* Added secret detection logic to Azure service principal crawler
([#950](#950)).
* Create storage credentials based on instance profiles and existing
roles ([#869](#869)).
* Enforced `protected-access` pylint rule
([#956](#956)).
* Enforced `pylint` on unit and integration test code
([#953](#953)).
* Enforcing `invalid-name` pylint rule
([#957](#957)).
* Fixed AzureResourcePermissions.load to call Installation.load
([#962](#962)).
* Fixed installer script to reuse an existing UCX Cluster policy if
present ([#964](#964)).
* More `pylint` tuning
([#958](#958)).
* Refactor `workspace_client_mock` to have combine fixtures stored in
separate JSON files
([#955](#955)).

Dependency updates:

* Updated databricks-sdk requirement from ~=0.19.0 to ~=0.20.0
([#961](#961)).
dmoore247 pushed a commit that referenced this pull request Mar 23, 2024
dmoore247 pushed a commit that referenced this pull request Mar 23, 2024
* Added secret detection logic to Azure service principal crawler
([#950](#950)).
* Create storage credentials based on instance profiles and existing
roles ([#869](#869)).
* Enforced `protected-access` pylint rule
([#956](#956)).
* Enforced `pylint` on unit and integration test code
([#953](#953)).
* Enforcing `invalid-name` pylint rule
([#957](#957)).
* Fixed AzureResourcePermissions.load to call Installation.load
([#962](#962)).
* Fixed installer script to reuse an existing UCX Cluster policy if
present ([#964](#964)).
* More `pylint` tuning
([#958](#958)).
* Refactor `workspace_client_mock` to have combine fixtures stored in
separate JSON files
([#955](#955)).

Dependency updates:

* Updated databricks-sdk requirement from ~=0.19.0 to ~=0.20.0
([#961](#961)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant