Skip to content

Skip scanning objects that were removed on platform side since the last scan time, so that integration tests are less flaky#922

Merged
nfx merged 9 commits intomainfrom
feature/issue-897-handle-missing
Feb 8, 2024
Merged

Skip scanning objects that were removed on platform side since the last scan time, so that integration tests are less flaky#922
nfx merged 9 commits intomainfrom
feature/issue-897-handle-missing

Conversation

@larsgeorge-db
Copy link
Copy Markdown
Contributor

@larsgeorge-db larsgeorge-db commented Feb 8, 2024

Changes

Adds handling of objects that may not be present and the API is throwing an exception to indicate this. While it is not expected to happen, during testing this is triggered at times and causes failures of the integration tests. Log instead and continue.

Linked issues

Resolves #897

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (baf3984) 86.55% compared to head (dde99da) 86.75%.

Files Patch % Lines
...tabricks/labs/ucx/workspace_access/verification.py 68.75% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #922      +/-   ##
==========================================
+ Coverage   86.55%   86.75%   +0.20%     
==========================================
  Files          41       41              
  Lines        5162     5196      +34     
  Branches      938      938              
==========================================
+ Hits         4468     4508      +40     
+ Misses        481      475       -6     
  Partials      213      213              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@nfx nfx changed the title Added handling of missing object. Skip scanning objects that were removed on platform side since the last scan time, so that integration tests are less flaky Feb 8, 2024
@nfx nfx merged commit 2853d39 into main Feb 8, 2024
@nfx nfx deleted the feature/issue-897-handle-missing branch February 8, 2024 19:50
nfx added a commit that referenced this pull request Feb 9, 2024
* Added CLI Command `databricks labs ucx save-uc-compatible-roles` ([#863](#863)).
* Added dashboard widget with table count by storage and format ([#852](#852)).
* Added verification of group permissions ([#841](#841)).
* Checking pipeline cluster config and cluster policy in 'crawl_pipelines' task ([#864](#864)).
* Created cluster policy (ucx-policy) to be used by all UCX compute. This may require customers to reinstall UCX. ([#853](#853)).
* Skip scanning objects that were removed on platform side since the last scan time, so that integration tests are less flaky ([#922](#922)).
* Updated assessment documentation ([#873](#873)).

Dependency updates:

 * Updated databricks-sdk requirement from ~=0.18.0 to ~=0.19.0 ([#930](#930)).
@nfx nfx mentioned this pull request Feb 9, 2024
nfx added a commit that referenced this pull request Feb 9, 2024
* Added CLI Command `databricks labs ucx save-uc-compatible-roles`
([#863](#863)).
* Added dashboard widget with table count by storage and format
([#852](#852)).
* Added verification of group permissions
([#841](#841)).
* Checking pipeline cluster config and cluster policy in
'crawl_pipelines' task
([#864](#864)).
* Created cluster policy (ucx-policy) to be used by all UCX compute.
This may require customers to reinstall UCX.
([#853](#853)).
* Skip scanning objects that were removed on platform side since the
last scan time, so that integration tests are less flaky
([#922](#922)).
* Updated assessment documentation
([#873](#873)).

Dependency updates:

* Updated databricks-sdk requirement from ~=0.18.0 to ~=0.19.0
([#930](#930)).
dmoore247 pushed a commit that referenced this pull request Mar 23, 2024
…st scan time, so that integration tests are less flaky (#922)

## Changes
Adds handling of objects that may not be present and the API is throwing
an exception to indicate this. While it is not expected to happen,
during testing this is triggered at times and causes failures of the
integration tests. Log instead and continue.

### Linked issues

Resolves #897
dmoore247 pushed a commit that referenced this pull request Mar 23, 2024
* Added CLI Command `databricks labs ucx save-uc-compatible-roles`
([#863](#863)).
* Added dashboard widget with table count by storage and format
([#852](#852)).
* Added verification of group permissions
([#841](#841)).
* Checking pipeline cluster config and cluster policy in
'crawl_pipelines' task
([#864](#864)).
* Created cluster policy (ucx-policy) to be used by all UCX compute.
This may require customers to reinstall UCX.
([#853](#853)).
* Skip scanning objects that were removed on platform side since the
last scan time, so that integration tests are less flaky
([#922](#922)).
* Updated assessment documentation
([#873](#873)).

Dependency updates:

* Updated databricks-sdk requirement from ~=0.18.0 to ~=0.19.0
([#930](#930)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Handle missing items in assessment loops

2 participants