Added assessment for the incompatible RunSubmit API usages#849
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
========================================
Coverage 88.10% 88.10%
========================================
Files 45 45
Lines 5622 5743 +121
Branches 1017 1043 +26
========================================
+ Hits 4953 5060 +107
- Misses 450 458 +8
- Partials 219 225 +6 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Duplicate of #395 |
nfx
requested changes
Jan 30, 2024
Contributor
nfx
requested changes
Feb 2, 2024
Collaborator
nfx
left a comment
There was a problem hiding this comment.
A lot of duplicates, not acceptable shape.
nfx
requested changes
Feb 6, 2024
Collaborator
nfx
left a comment
There was a problem hiding this comment.
This implementation is incorrect and changes places it must not touch
a88f738 to
2c5ced4
Compare
nfx
requested changes
Mar 1, 2024
| "warehouse_id": "123", | ||
| "project_directory": "abc/def", | ||
| "commands": [ | ||
| "Sit!", |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has the following changes:
RunSubmitAPI usages #266 by implementing a crawler that focuses on detecting submit runs with potential compatibility issues. It is important to note that not all submit runs will be analyzed, as they do not directly contribute to the migration process. The crawler serves to identify incompatible groups of submit runs by analyzing their tasks and clustering them based on unique hash values._retrieve_hash_values_from_taskfunction, which retrieves necessary details from the task for accurate hash calculation.In summary, this PR introduces a new crawler to detect incompatible submit runs by analyzing tasks, calculating unique hashes, and consolidating submit runs under the same hash into pseudo-jobs. The crawler returns a list of pseudo-jobs along with their assessment results, which enables users to make informed decisions regarding the compatibility status of their submit runs.