Convert to SDK exceptions for RuntimeBackend query executions#769
Merged
Conversation
Convert to SDK exceptions for RuntimeBackend query executions.
pritishpai
had a problem deploying
to
account-admin
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
==========================================
+ Coverage 81.84% 81.93% +0.08%
==========================================
Files 39 39
Lines 4495 4516 +21
Branches 831 835 +4
==========================================
+ Hits 3679 3700 +21
Misses 606 606
Partials 210 210 ☔ View full report in Codecov by Sentry. |
nfx
requested changes
Jan 10, 2024
Collaborator
nfx
left a comment
nfx
left a comment
There was a problem hiding this comment.
Implementation is incorrect and too complicated, simplify and make it also work with fetch() method
Simplifying error handling, more integration and unit tests.
pritishpai
had a problem deploying
to
account-admin
GitHub Actions
Failure
pritishpai
had a problem deploying
to
account-admin
GitHub Actions
Failure
pritishpai
had a problem deploying
to
account-admin
GitHub Actions
Failure
nfx
requested changes
Jan 11, 2024
| self._spark.sql(sql) | ||
| try: | ||
| immediate_response = self._spark.sql(sql) | ||
| status = immediate_response.status |
Collaborator
There was a problem hiding this comment.
There's no status in spark sql response, this is incorrect
| error_message = str(e) | ||
| self._raise_spark_sql_exceptions(error_message) | ||
|
|
||
| if status is None: |
Collaborator
There was a problem hiding this comment.
Remove reliance on status from here altogether
pritishpai
had a problem deploying
to
account-admin
GitHub Actions
Failure
nfx
requested changes
Jan 11, 2024
pritishpai
had a problem deploying
to
account-admin
GitHub Actions
Failure
pritishpai
had a problem deploying
to
account-admin
GitHub Actions
Failure
nfx
approved these changes
Jan 11, 2024
nfx
added a commit
that referenced
this pull request
Jan 12, 2024
* Added assessment step to estimate the size of DBFS root tables ([#741](#741)). * Added `TableMapping` functionality to table migrate ([#752](#752)). * Added `databricks labs ucx move` command to move tables and schemas between catalogs ([#756](#756)). * Added functionality to determine migration method based on DBFS Root ([#759](#759)). * Added `get_tables_to_migrate` functionality in the mapping module ([#755](#755)). * Added retry and rate limit to rename workspace group operation and corrected rate limit for reflecting account groups to workspace ([#751](#751)). * Adopted `databricks-labs-blueprint` library for common utilities to be reused in the other projects ([#758](#758)). * Converted `RuntimeBackend` query executions exceptions to SDK exceptions ([#769](#769)). * Fixed issue with missing users and temp groups after workspace-local groups migration and skip table when crawling table size if it does not exist anymore ([#770](#770)). * Improved error handling by not failing group rename step if a group was removed from account before reflecting it to workspace ([#762](#762)). * Improved error message inference from failed workflow runs ([#753](#753)). * Moved `TablesMigrate` to a separate module ([#747](#747)). * Reorganized assessment dashboard to increase readability ([#738](#738)). * Updated databricks-sdk requirement from ~=0.16.0 to ~=0.17.0 ([#773](#773)). * Verify metastore exists in current workspace ([#735](#735)).
Merged
nfx
added a commit
that referenced
this pull request
Jan 12, 2024
* Added assessment step to estimate the size of DBFS root tables ([#741](#741)). * Added `TableMapping` functionality to table migrate ([#752](#752)). * Added `databricks labs ucx move` command to move tables and schemas between catalogs ([#756](#756)). * Added functionality to determine migration method based on DBFS Root ([#759](#759)). * Added `get_tables_to_migrate` functionality in the mapping module ([#755](#755)). * Added retry and rate limit to rename workspace group operation and corrected rate limit for reflecting account groups to workspace ([#751](#751)). * Adopted `databricks-labs-blueprint` library for common utilities to be reused in the other projects ([#758](#758)). * Converted `RuntimeBackend` query executions exceptions to SDK exceptions ([#769](#769)). * Fixed issue with missing users and temp groups after workspace-local groups migration and skip table when crawling table size if it does not exist anymore ([#770](#770)). * Improved error handling by not failing group rename step if a group was removed from account before reflecting it to workspace ([#762](#762)). * Improved error message inference from failed workflow runs ([#753](#753)). * Moved `TablesMigrate` to a separate module ([#747](#747)). * Reorganized assessment dashboard to increase readability ([#738](#738)). * Updated databricks-sdk requirement from ~=0.16.0 to ~=0.17.0 ([#773](#773)). * Verify metastore exists in current workspace ([#735](#735)).
FastLee
pushed a commit
that referenced
this pull request
Jan 19, 2024
Convert the query execution exceptions to SDK exceptions like NotFound, PermissionDenied and SyntaxError (currently used BadRequest to map syntax errors). Integration and unit tests added. Fixes #726 --------- Co-authored-by: Serge Smertin <[email protected]>
FastLee
pushed a commit
that referenced
this pull request
Jan 19, 2024
* Added assessment step to estimate the size of DBFS root tables ([#741](#741)). * Added `TableMapping` functionality to table migrate ([#752](#752)). * Added `databricks labs ucx move` command to move tables and schemas between catalogs ([#756](#756)). * Added functionality to determine migration method based on DBFS Root ([#759](#759)). * Added `get_tables_to_migrate` functionality in the mapping module ([#755](#755)). * Added retry and rate limit to rename workspace group operation and corrected rate limit for reflecting account groups to workspace ([#751](#751)). * Adopted `databricks-labs-blueprint` library for common utilities to be reused in the other projects ([#758](#758)). * Converted `RuntimeBackend` query executions exceptions to SDK exceptions ([#769](#769)). * Fixed issue with missing users and temp groups after workspace-local groups migration and skip table when crawling table size if it does not exist anymore ([#770](#770)). * Improved error handling by not failing group rename step if a group was removed from account before reflecting it to workspace ([#762](#762)). * Improved error message inference from failed workflow runs ([#753](#753)). * Moved `TablesMigrate` to a separate module ([#747](#747)). * Reorganized assessment dashboard to increase readability ([#738](#738)). * Updated databricks-sdk requirement from ~=0.16.0 to ~=0.17.0 ([#773](#773)). * Verify metastore exists in current workspace ([#735](#735)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the query execution exceptions to SDK exceptions like NotFound, PermissionDenied and SyntaxError (currently used BadRequest to map syntax errors).
Integration and unit tests added.
Fixes #726