Skip to content

Fixed flaky 'test_group_name_change_substitute'#739

Merged
nfx merged 1 commit intomainfrom
fix/group_test_error
Dec 26, 2023
Merged

Fixed flaky 'test_group_name_change_substitute'#739
nfx merged 1 commit intomainfrom
fix/group_test_error

Conversation

@FastLee
Copy link
Copy Markdown
Contributor

@FastLee FastLee commented Dec 26, 2023

Addressed Error with Group Testing test_group_name_change_substitute by generating group names randomly.

@FastLee FastLee requested review from a team and renardeinside December 26, 2023 00:11
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6cdb248) 79.43% compared to head (6168a10) 79.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #739   +/-   ##
=======================================
  Coverage   79.43%   79.43%           
=======================================
  Files          42       42           
  Lines        4411     4411           
  Branches      819      819           
=======================================
  Hits         3504     3504           
  Misses        693      693           
  Partials      214      214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfx nfx changed the title Addressed Error with Group Testing test_group_name_change_substitute Fixed flaky 'test_group_name_change_substitute' Dec 26, 2023
@nfx nfx merged commit 6c89e67 into main Dec 26, 2023
@nfx nfx deleted the fix/group_test_error branch December 26, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants