Skip to content

Allow specifying a group list when group match options are used#725

Merged
nfx merged 2 commits intomainfrom
fix/group_mapping_list_721
Dec 22, 2023
Merged

Allow specifying a group list when group match options are used#725
nfx merged 2 commits intomainfrom
fix/group_mapping_list_721

Conversation

@FastLee
Copy link
Copy Markdown
Contributor

@FastLee FastLee commented Dec 22, 2023

closes #721

Added option to select a group list when one of the group matching option is used.
Added unit tests.

@FastLee FastLee requested review from a team and stikkireddy December 22, 2023 02:34
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3537abd) 78.90% compared to head (8bc1034) 79.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
+ Coverage   78.90%   79.43%   +0.52%     
==========================================
  Files          42       42              
  Lines        4409     4410       +1     
  Branches      818      819       +1     
==========================================
+ Hits         3479     3503      +24     
+ Misses        720      693      -27     
- Partials      210      214       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread tests/unit/test_install.py Outdated
Comment thread tests/unit/workspace_access/test_groups.py Outdated
@FastLee FastLee requested a review from nfx December 22, 2023 13:09
@FastLee FastLee enabled auto-merge December 22, 2023 13:09
@FastLee FastLee force-pushed the fix/group_mapping_list_721 branch from b43a88b to 8bc1034 Compare December 22, 2023 13:10
@FastLee FastLee requested a review from nfx December 22, 2023 13:12
@nfx nfx disabled auto-merge December 22, 2023 14:59
@nfx nfx merged commit 31ab7b7 into main Dec 22, 2023
@nfx nfx deleted the fix/group_mapping_list_721 branch December 22, 2023 14:59
nfx added a commit that referenced this pull request Dec 28, 2023
* Added `databricks labs ucx repair-run --step ...` CLI command for repair run of any failed workflows, like `assessment`, `migrate-groups` etc. ([#724](#724)).
* Added `databricks labs ucx revert-migrated-table` command ([#729](#729)).
* Allow specifying a group list when group match options are used ([#725](#725)).
* Fixed installation issue when upgrading from an older version of the tool and improve logs ([#740](#740)).
* Renamed summary panel from Failure Summary to Assessment Summary ([#733](#733)).
* Retry internal error when getting permissions and update legacy table ACL documentation ([#728](#728)).
* Speedup installer execution ([#727](#727)).
@nfx nfx mentioned this pull request Dec 28, 2023
nfx added a commit that referenced this pull request Dec 28, 2023
* Added `databricks labs ucx repair-run --step ...` CLI command for
repair run of any failed workflows, like `assessment`, `migrate-groups`
etc. ([#724](#724)).
* Added `databricks labs ucx revert-migrated-table` command
([#729](#729)).
* Allow specifying a group list when group match options are used
([#725](#725)).
* Fixed installation issue when upgrading from an older version of the
tool and improve logs
([#740](#740)).
* Renamed summary panel from Failure Summary to Assessment Summary
([#733](#733)).
* Retry internal error when getting permissions and update legacy table
ACL documentation
([#728](#728)).
* Speedup installer execution
([#727](#727)).
HariGS-DB pushed a commit that referenced this pull request Jan 2, 2024
* Added `databricks labs ucx repair-run --step ...` CLI command for
repair run of any failed workflows, like `assessment`, `migrate-groups`
etc. ([#724](#724)).
* Added `databricks labs ucx revert-migrated-table` command
([#729](#729)).
* Allow specifying a group list when group match options are used
([#725](#725)).
* Fixed installation issue when upgrading from an older version of the
tool and improve logs
([#740](#740)).
* Renamed summary panel from Failure Summary to Assessment Summary
([#733](#733)).
* Retry internal error when getting permissions and update legacy table
ACL documentation
([#728](#728)).
* Speedup installer execution
([#727](#727)).
FastLee added a commit that referenced this pull request Jan 19, 2024
closes #721 

Added option to select a group list when one of the group matching
option is used.
Added unit tests.
FastLee pushed a commit that referenced this pull request Jan 19, 2024
* Added `databricks labs ucx repair-run --step ...` CLI command for
repair run of any failed workflows, like `assessment`, `migrate-groups`
etc. ([#724](#724)).
* Added `databricks labs ucx revert-migrated-table` command
([#729](#729)).
* Allow specifying a group list when group match options are used
([#725](#725)).
* Fixed installation issue when upgrading from an older version of the
tool and improve logs
([#740](#740)).
* Renamed summary panel from Failure Summary to Assessment Summary
([#733](#733)).
* Retry internal error when getting permissions and update legacy table
ACL documentation
([#728](#728)).
* Speedup installer execution
([#727](#727)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow group mapping and group list selection on the installer

2 participants