Added interactive wizard for `databricks labs uninstall ucx` command by HariGS-DB · Pull Request #657 · databrickslabs/ucx

HariGS-DB · 2023-12-01T01:49:59Z

This changes includes updates to the installation code base. With the new databricks cli , one can install ucx using databricks labs install ucx. This pr includes changes required to do uninstall ucx from databricks cli using databricks labs uninstall ucx.
It asks user to confirm if ucx workspace set up should be uninstalled. other wise only uninstall locally
it also asks if user wants to delete the inventory database, if not it will keep the inventory database
default behaviour is to delete ucx install folder, all the jobs, inventory database and any warehouse created during installation.

codecov · 2023-12-01T01:51:52Z

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (05a862f) 82.44% compared to head (10a33bf) 82.61%.

Files	Patch %	Lines
src/databricks/labs/ucx/install.py	91.83%	1 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #657      +/-   ##
==========================================
+ Coverage   82.44%   82.61%   +0.16%     
==========================================
  Files          35       36       +1     
  Lines        3544     3601      +57     
  Branches      662      668       +6     
==========================================
+ Hits         2922     2975      +53     
- Misses        474      475       +1     
- Partials      148      151       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nfx

can you make a constant for a warehouse prefix and change it for install step as well?

src/databricks/labs/ucx/install.py

src/databricks/labs/ucx/uninstall.py

src/databricks/labs/ucx/install.py

Co-authored-by: Serge Smertin <[email protected]>

* Added `databricks labs ucx create-table-mapping` and `databricks labs ucx manual-workspace-info` commands for CLI ([#682](#682)). * Added `databricks labs ucx installations` command ([#679](#679)). * Added `databricks labs ucx skip --schema ... --table ...` command to mark table/schema for skipping in the table migration process ([#680](#680)). * Added `workspace_group_name` and `account_group_name` to `make_ucx_group` fixture ([#664](#664)). * Added capturing `ANY FILE` and `ANONYMOUS FUNCTION` grants ([#653](#653)). * Added cluster override and handle case of write protected DBFS ([#610](#610)). * Added cluster policy selector in the installer ([#655](#655)). * Added detailed UCX pre-requisite information to README.md ([#689](#689)). * Added filters to run only cloud specific task ([#681](#681)). * Added interactive wizard for `databricks labs uninstall ucx` command ([#657](#657)). * Added more granular error retry logic ([#704](#704)). * Added parallel fetching of registered model identifiers to speed-up assessment workflow ([#691](#691)). * Added retry on workspace listing ([#659](#659)). * Added support for mapping workspace group to account group by prefix/suffix/regex/external id ([#650](#650)). * Changed cluster security mode from NONE to LEGACY_SINGLE_USER, as `crawl_tables` was failing when run on non-UC Workspace in No Isolation mode with unable to access the config file ([#661](#661)). * Changed the fields of the table "Tables" to lower case ([#684](#684)). * Cleanup README.md ([#695](#695)). * Cleanup installer framework and speed up test execution ([#711](#711)). * Decouple group configuration from `install.py` ([#714](#714)). * Enabled integration tests for `EXTERNAL` table migrations ([#677](#677)). * Enforced `mypy` validation ([#713](#713)). * Filtering out inventory database from loading into tables and filtering out the same from grant detail view ([#705](#705)). * Fixed documentation for `reflect_account_groups_on_workspace` task and updated `CONTRIBUTING.md` guide ([#654](#654)). * Fixed for secret scope apply task always raises ValueError ([#683](#683)). * Fixed some flaky integration tests ([#700](#700)). * More `mypy` chores ([#697](#697)). * Moved `ExternalLocations` and `Mounts` to `locations` module ([#692](#692)). * New CLI command for workspace mapping ([#678](#678)). * No more `mypy` chores after this ([#699](#699)). * Reduce server load for getting workspace groups and their members ([#666](#666)). * Some `mypy` chores ([#696](#696)). * Throwing ManyError on migrate-groups tasks ([#710](#710)). * Updated databricks-sdk requirement from ~=0.13.0 to ~=0.14.0 ([#651](#651)). * Updated databricks-sdk requirement from ~=0.14.0 to ~=0.15.0 ([#687](#687)). * Updated databricks-sdk requirement from ~=0.15.0 to ~=0.16.0 ([#712](#712)). * Updated installation documentation to use Databricks CLI ([#686](#686)).

* Added `databricks labs ucx create-table-mapping` and `databricks labs ucx manual-workspace-info` commands for CLI ([#682](#682)). * Added `databricks labs ucx installations` command ([#679](#679)). * Added `databricks labs ucx skip --schema ... --table ...` command to mark table/schema for skipping in the table migration process ([#680](#680)). * Added `workspace_group_name` and `account_group_name` to `make_ucx_group` fixture ([#664](#664)). * Added capturing `ANY FILE` and `ANONYMOUS FUNCTION` grants ([#653](#653)). * Added cluster override and handle case of write protected DBFS ([#610](#610)). * Added cluster policy selector in the installer ([#655](#655)). * Added detailed UCX pre-requisite information to README.md ([#689](#689)). * Added filters to run only cloud specific task ([#681](#681)). * Added interactive wizard for `databricks labs uninstall ucx` command ([#657](#657)). * Added more granular error retry logic ([#704](#704)). * Added parallel fetching of registered model identifiers to speed-up assessment workflow ([#691](#691)). * Added retry on workspace listing ([#659](#659)). * Added support for mapping workspace group to account group by prefix/suffix/regex/external id ([#650](#650)). * Changed cluster security mode from NONE to LEGACY_SINGLE_USER, as `crawl_tables` was failing when run on non-UC Workspace in No Isolation mode with unable to access the config file ([#661](#661)). * Changed the fields of the table "Tables" to lower case ([#684](#684)). * Cleanup README.md ([#695](#695)). * Cleanup installer framework and speed up test execution ([#711](#711)). * Decouple group configuration from `install.py` ([#714](#714)). * Enabled integration tests for `EXTERNAL` table migrations ([#677](#677)). * Enforced `mypy` validation ([#713](#713)). * Filtering out inventory database from loading into tables and filtering out the same from grant detail view ([#705](#705)). * Fixed documentation for `reflect_account_groups_on_workspace` task and updated `CONTRIBUTING.md` guide ([#654](#654)). * Fixed for secret scope apply task always raises ValueError ([#683](#683)). * Fixed some flaky integration tests ([#700](#700)). * More `mypy` chores ([#697](#697)). * Moved `ExternalLocations` and `Mounts` to `locations` module ([#692](#692)). * New CLI command for workspace mapping ([#678](#678)). * No more `mypy` chores after this ([#699](#699)). * Reduce server load for getting workspace groups and their members ([#666](#666)). * Some `mypy` chores ([#696](#696)). * Throwing ManyError on migrate-groups tasks ([#710](#710)). * Updated installation documentation to use Databricks CLI ([#686](#686)). Dependency updates: * Updated databricks-sdk requirement from ~=0.13.0 to ~=0.14.0 ([#651](#651)). * Updated databricks-sdk requirement from ~=0.14.0 to ~=0.15.0 ([#687](#687)). * Updated databricks-sdk requirement from ~=0.15.0 to ~=0.16.0 ([#712](#712)).

* Added `databricks labs ucx create-table-mapping` and `databricks labs ucx manual-workspace-info` commands for CLI ([#682](#682)). * Added `databricks labs ucx installations` command ([#679](#679)). * Added `databricks labs ucx skip --schema ... --table ...` command to mark table/schema for skipping in the table migration process ([#680](#680)). * Added `databricks labs ucx validate-external-locations` command for cli ([#715](#715)). * Added `workspace_group_name` and `account_group_name` to `make_ucx_group` fixture ([#664](#664)). * Added capturing `ANY FILE` and `ANONYMOUS FUNCTION` grants ([#653](#653)). * Added cluster override and handle case of write protected DBFS ([#610](#610)). * Added cluster policy selector in the installer ([#655](#655)). * Added detailed UCX pre-requisite information to README.md ([#689](#689)). * Added filters to run only cloud specific task ([#681](#681)). * Added interactive wizard for `databricks labs uninstall ucx` command ([#657](#657)). * Added more granular error retry logic ([#704](#704)). * Added parallel fetching of registered model identifiers to speed-up assessment workflow ([#691](#691)). * Added retry on workspace listing ([#659](#659)). * Added support for mapping workspace group to account group by prefix/suffix/regex/external id ([#650](#650)). * Changed cluster security mode from NONE to LEGACY_SINGLE_USER, as `crawl_tables` was failing when run on non-UC Workspace in No Isolation mode with unable to access the config file ([#661](#661)). * Changed the fields of the table "Tables" to lower case ([#684](#684)). * Cleanup README.md ([#695](#695)). * Cleanup installer framework and speed up test execution ([#711](#711)). * Decouple group configuration from `install.py` ([#714](#714)). * Enabled integration tests for `EXTERNAL` table migrations ([#677](#677)). * Enforced `mypy` validation ([#713](#713)). * Filtering out inventory database from loading into tables and filtering out the same from grant detail view ([#705](#705)). * Fixed documentation for `reflect_account_groups_on_workspace` task and updated `CONTRIBUTING.md` guide ([#654](#654)). * Fixed for secret scope apply task always raises ValueError ([#683](#683)). * Fixed some flaky integration tests ([#700](#700)). * More `mypy` chores ([#697](#697)). * Moved `ExternalLocations` and `Mounts` to `locations` module ([#692](#692)). * New CLI command for workspace mapping ([#678](#678)). * No more `mypy` chores after this ([#699](#699)). * Reduce server load for getting workspace groups and their members ([#666](#666)). * Some `mypy` chores ([#696](#696)). * Throwing ManyError on migrate-groups tasks ([#710](#710)). * Updated installation documentation to use Databricks CLI ([#686](#686)). Dependency updates: * Updated databricks-sdk requirement from ~=0.13.0 to ~=0.14.0 ([#651](#651)). * Updated databricks-sdk requirement from ~=0.14.0 to ~=0.15.0 ([#687](#687)). * Updated databricks-sdk requirement from ~=0.15.0 to ~=0.16.0 ([#712](#712)).

* Added `databricks labs ucx create-table-mapping` and `databricks labs ucx manual-workspace-info` commands for CLI ([#682](#682)). * Added `databricks labs ucx ensure-assessment-run` to CLI commands ([#708](#708)). * Added `databricks labs ucx installations` command ([#679](#679)). * Added `databricks labs ucx skip --schema ... --table ...` command to mark table/schema for skipping in the table migration process ([#680](#680)). * Added `databricks labs ucx validate-external-locations` command for cli ([#715](#715)). * Added capturing `ANY FILE` and `ANONYMOUS FUNCTION` grants ([#653](#653)). * Added cluster override and handle case of write protected DBFS ([#610](#610)). * Added cluster policy selector in the installer ([#655](#655)). * Added detailed UCX pre-requisite information to README.md ([#689](#689)). * Added interactive wizard for `databricks labs uninstall ucx` command ([#657](#657)). * Added more granular error retry logic ([#704](#704)). * Added parallel fetching of registered model identifiers to speed-up assessment workflow ([#691](#691)). * Added retry on workspace listing ([#659](#659)). * Added support for mapping workspace group to account group by prefix/suffix/regex/external id ([#650](#650)). * Changed cluster security mode from NONE to LEGACY_SINGLE_USER, as `crawl_tables` was failing when run on non-UC Workspace in No Isolation mode with unable to access the config file ([#661](#661)). * Changed the fields of the table "Tables" to lower case ([#684](#684)). * Enabled integration tests for `EXTERNAL` table migrations ([#677](#677)). * Enforced `mypy` validation ([#713](#713)). * Filtering out inventory database from loading into tables and filtering out the same from grant detail view ([#705](#705)). * Fixed documentation for `reflect_account_groups_on_workspace` task and updated `CONTRIBUTING.md` guide ([#654](#654)). * Fixed secret scope apply task to raise ValueError ([#683](#683)). * Fixed legacy table ACL ownership migration and other integration testing issues ([#722](#722)). * Fixed some flaky integration tests ([#700](#700)). * New CLI command for workspace mapping ([#678](#678)). * Reduce server load for getting workspace groups and their members ([#666](#666)). * Throwing ManyError on migrate-groups tasks ([#710](#710)). * Updated installation documentation to use Databricks CLI ([#686](#686)). Dependency updates: * Updated databricks-sdk requirement from ~=0.13.0 to ~=0.14.0 ([#651](#651)). * Updated databricks-sdk requirement from ~=0.14.0 to ~=0.15.0 ([#687](#687)). * Updated databricks-sdk requirement from ~=0.15.0 to ~=0.16.0 ([#712](#712)).

HariGS-DB added 6 commits November 29, 2023 22:29

first draft commit

8635707

first draft commit

565e37d

added functionality for uninstall

b69ad95

statefile path fix

d35b6c9

added unit testing

8b07288

added integration testing

ce7f423

HariGS-DB requested review from a team and mwojtyczka December 1, 2023 01:50

HariGS-DB linked an issue Dec 1, 2023 that may be closed by this pull request

Add cleanup option to the install script #276

Closed

HariGS-DB had a problem deploying to account-admin December 1, 2023 01:50 — with GitHub Actions Failure

HariGS-DB removed the request for review from mwojtyczka December 1, 2023 01:50

fmting

dc14a69

HariGS-DB had a problem deploying to account-admin December 1, 2023 01:52 — with GitHub Actions Failure

HariGS-DB requested a review from nfx December 1, 2023 01:53

improving test coverage

c389dbd

HariGS-DB had a problem deploying to account-admin December 1, 2023 02:28 — with GitHub Actions Failure

nfx approved these changes Dec 1, 2023

View reviewed changes

Update src/databricks/labs/ucx/install.py

fd7bf52

Co-authored-by: Serge Smertin <[email protected]>

HariGS-DB had a problem deploying to account-admin December 1, 2023 10:37 — with GitHub Actions Failure

Update src/databricks/labs/ucx/install.py

851bc42

Co-authored-by: Serge Smertin <[email protected]>

HariGS-DB had a problem deploying to account-admin December 1, 2023 10:37 — with GitHub Actions Failure

Update src/databricks/labs/ucx/install.py

6acbb8c

Co-authored-by: Serge Smertin <[email protected]>

HariGS-DB had a problem deploying to account-admin December 1, 2023 10:38 — with GitHub Actions Failure

Update src/databricks/labs/ucx/install.py

c1be3db

Co-authored-by: Serge Smertin <[email protected]>

HariGS-DB had a problem deploying to account-admin December 1, 2023 10:38 — with GitHub Actions Failure

Update src/databricks/labs/ucx/install.py

4445bbb

Co-authored-by: Serge Smertin <[email protected]>

HariGS-DB had a problem deploying to account-admin December 1, 2023 10:39 — with GitHub Actions Failure

Update src/databricks/labs/ucx/install.py

4504f64

Co-authored-by: Serge Smertin <[email protected]>

HariGS-DB had a problem deploying to account-admin December 1, 2023 10:40 — with GitHub Actions Failure

Update src/databricks/labs/ucx/uninstall.py

4aec5bd

Co-authored-by: Serge Smertin <[email protected]>

HariGS-DB had a problem deploying to account-admin December 1, 2023 10:41 — with GitHub Actions Failure

constant for warehouse prefix

10a33bf

HariGS-DB had a problem deploying to account-admin December 1, 2023 11:18 — with GitHub Actions Failure

nfx approved these changes Dec 1, 2023

View reviewed changes

nfx changed the title ~~Add Uninstall ucx functionality in databricks labs cli~~ Added interactive wizard for databricks labs uninstall ucx command Dec 1, 2023

nfx merged commit f25a266 into main Dec 1, 2023

nfx deleted the feature/uninstall_ucx branch December 1, 2023 13:06

nfx mentioned this pull request Dec 21, 2023

Release v0.7.0 #719

Closed

nfx mentioned this pull request Dec 21, 2023

Release v0.7.0 #720

Closed

nfx mentioned this pull request Dec 21, 2023

Release v0.7.0 #723

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added interactive wizard for `databricks labs uninstall ucx` command#657

Added interactive wizard for `databricks labs uninstall ucx` command#657
nfx merged 16 commits intomainfrom
feature/uninstall_ucx

HariGS-DB commented Dec 1, 2023

Uh oh!

codecov bot commented Dec 1, 2023 •

edited

Loading

Uh oh!

nfx left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

HariGS-DB commented Dec 1, 2023

Uh oh!

codecov bot commented Dec 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nfx left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Dec 1, 2023 •

edited

Loading