Skip to content

Retry set/update permissions when possible and assess the changes in the workspace#519

Merged
nfx merged 16 commits intomainfrom
feature/retry-redash-permissions
Oct 30, 2023
Merged

Retry set/update permissions when possible and assess the changes in the workspace#519
nfx merged 16 commits intomainfrom
feature/retry-redash-permissions

Conversation

@tnguyen-db
Copy link
Copy Markdown
Contributor

@tnguyen-db tnguyen-db commented Oct 27, 2023

Duplicated from: #507

@tnguyen-db tnguyen-db requested a review from a team October 27, 2023 19:12
@tnguyen-db tnguyen-db changed the title Feature/retry redash permissions Retry set/update permissions when possible and assess the changes in the workspace Oct 27, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Merging #519 (7a8a800) into main (f0c61a4) will increase coverage by 0.48%.
The diff coverage is 100.00%.

❗ Current head 7a8a800 differs from pull request most recent head 8448cc6. Consider uploading reports for the commit 8448cc6 to get more accurate results

@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
+ Coverage   80.44%   80.93%   +0.48%     
==========================================
  Files          31       31              
  Lines        3319     3383      +64     
  Branches      651      655       +4     
==========================================
+ Hits         2670     2738      +68     
+ Misses        492      491       -1     
+ Partials      157      154       -3
Files Coverage Δ
...rc/databricks/labs/ucx/workspace_access/generic.py 92.79% <100.00%> (+1.47%) ⬆️
src/databricks/labs/ucx/workspace_access/redash.py 87.82% <100.00%> (+2.56%) ⬆️
src/databricks/labs/ucx/workspace_access/scim.py 100.00% <100.00%> (+3.57%) ⬆️

@tnguyen-db tnguyen-db temporarily deployed to account-admin October 30, 2023 09:41 — with GitHub Actions Inactive
@tnguyen-db tnguyen-db force-pushed the feature/retry-redash-permissions branch from 79f7134 to 4924012 Compare October 30, 2023 09:54
@tnguyen-db tnguyen-db force-pushed the feature/retry-redash-permissions branch from 4924012 to 297f2b4 Compare October 30, 2023 11:30
@tnguyen-db tnguyen-db force-pushed the feature/retry-redash-permissions branch from 297f2b4 to 79f7134 Compare October 30, 2023 13:22
@tnguyen-db tnguyen-db temporarily deployed to account-admin October 30, 2023 13:22 — with GitHub Actions Inactive
@tnguyen-db tnguyen-db temporarily deployed to account-admin October 30, 2023 14:36 — with GitHub Actions Inactive
@tnguyen-db tnguyen-db force-pushed the feature/retry-redash-permissions branch from 6ba1043 to 7a8a800 Compare October 30, 2023 15:03
@tnguyen-db tnguyen-db temporarily deployed to account-admin October 30, 2023 15:03 — with GitHub Actions Inactive
@tnguyen-db tnguyen-db enabled auto-merge October 30, 2023 15:47
@tnguyen-db tnguyen-db added this pull request to the merge queue Oct 30, 2023
@tnguyen-db tnguyen-db removed this pull request from the merge queue due to a manual request Oct 30, 2023
@tnguyen-db tnguyen-db force-pushed the feature/retry-redash-permissions branch from 7a8a800 to 8448cc6 Compare October 30, 2023 16:34
@tnguyen-db tnguyen-db temporarily deployed to account-admin October 30, 2023 17:21 — with GitHub Actions Inactive
@nfx nfx linked an issue Oct 30, 2023 that may be closed by this pull request
Add retry to redash permissions #489
Closed
@nfx nfx merged commit 142cf75 into main Oct 30, 2023
@nfx nfx deleted the feature/retry-redash-permissions branch October 30, 2023 18:07
nfx added a commit that referenced this pull request Nov 17, 2023
@nfx
Release v0.6.0
5aa1587 
**Breaking changes** (existing installations need to reinstall UCX and re-run assessment jobs)

 * Switched local group migration component to rename groups instead of creating backup groups ([#450](#450)).
 * Mitigate permissions loss in Table ACLs by folding grants belonging to the same principal, object id and object type together ([#512](#512)).

**New features**

 * Added support for the experimental Databricks CLI launcher ([#517](#517)).
 * Added support for external Hive Metastores including AWS Glue ([#400](#400)).
 * Added more views to assessment dashboard ([#474](#474)).
 * Added rate limit for creating backup group to increase stability ([#500](#500)).
 * Added deduplication for mount point list ([#569](#569)).
 * Added documentation to describe interaction with external Hive Metastores ([#473](#473)).
 * Added failure injection for job failure message propagation  ([#591](#591)).
 * Added uniqueness in the new warehouse name to avoid conflicts on installation ([#542](#542)).
 * Added a global init script to collect Hive Metastore lineage ([#513](#513)).
 * Added retry set/update permissions when possible and assess the changes in the workspace ([#519](#519)).
 * Use `~/.ucx/state.json` to store the state of both dashboards and jobs ([#561](#561)).

**Bug fixes**

 * Fixed handling for `OWN` table permissions ([#571](#571)).
 * Fixed handling of keys with and without values. ([#514](#514)).
 * Fixed integration test failures related to concurrent group delete ([#584](#584)).
 * Fixed issue with workspace listing process on None type `object_type` ([#481](#481)).
 * Fixed missing group entitlement migration bug ([#583](#583)).
 * Fixed entitlement application for account-level groups ([#529](#529)).
 * Fixed assessment throwing an error when the owner of an object is empty ([#485](#485)).
 * Fixed installer to migrate between different configuration file versions ([#596](#596)).
 * Fixed cluster policy crawler to be aware of deleted policies ([#486](#486)).
 * Improved error message for not null constraints violated ([#532](#532)).
 * Improved integration test resiliency ([#597](#597), [#594](#594), [#586](#586)).
 * Introduced Safer access to workspace objects' properties. ([#530](#530)).
 * Mitigated permissions loss in Table ACLs by running appliers with single thread ([#518](#518)).
 * Running apply permission task before assessment should display message ([#487](#487)).
 * Split integration tests from blocking the merge queue ([#496](#496)).
 * Support more than one dashboard per step ([#472](#472)).
 * Update databricks-sdk requirement from ~=0.11.0 to ~=0.12.0 ([#505](#505)).
 * Update databricks-sdk requirement from ~=0.12.0 to ~=0.13.0 ([#575](#575)).
@nfx nfx mentioned this pull request Nov 17, 2023
Merged
nfx added a commit that referenced this pull request Nov 17, 2023
@nfx
Release v0.6.0 (#598)
b4dab33 
**Breaking changes** (existing installations need to reinstall UCX and
re-run assessment jobs)

* Switched local group migration component to rename groups instead of
creating backup groups
([#450](#450)).
* Mitigate permissions loss in Table ACLs by folding grants belonging to
the same principal, object id and object type together
([#512](#512)).

**New features**

* Added support for the experimental Databricks CLI launcher
([#517](#517)).
* Added support for external Hive Metastores including AWS Glue
([#400](#400)).
* Added more views to assessment dashboard
([#474](#474)).
* Added rate limit for creating backup group to increase stability
([#500](#500)).
* Added deduplication for mount point list
([#569](#569)).
* Added documentation to describe interaction with external Hive
Metastores ([#473](#473)).
* Added failure injection for job failure message propagation
([#591](#591)).
* Added uniqueness in the new warehouse name to avoid conflicts on
installation ([#542](#542)).
* Added a global init script to collect Hive Metastore lineage
([#513](#513)).
* Added retry set/update permissions when possible and assess the
changes in the workspace
([#519](#519)).
* Use `~/.ucx/state.json` to store the state of both dashboards and jobs
([#561](#561)).

**Bug fixes**

* Fixed handling for `OWN` table permissions
([#571](#571)).
* Fixed handling of keys with and without values.
([#514](#514)).
* Fixed integration test failures related to concurrent group delete
([#584](#584)).
* Fixed issue with workspace listing process on None type `object_type`
([#481](#481)).
* Fixed missing group entitlement migration bug
([#583](#583)).
* Fixed entitlement application for account-level groups
([#529](#529)).
* Fixed assessment throwing an error when the owner of an object is
empty ([#485](#485)).
* Fixed installer to migrate between different configuration file
versions ([#596](#596)).
* Fixed cluster policy crawler to be aware of deleted policies
([#486](#486)).
* Improved error message for not null constraints violated
([#532](#532)).
* Improved integration test resiliency
([#597](#597),
[#594](#594),
[#586](#586)).
* Introduced Safer access to workspace objects' properties.
([#530](#530)).
* Mitigated permissions loss in Table ACLs by running appliers with
single thread ([#518](#518)).
* Running apply permission task before assessment should display message
([#487](#487)).
* Split integration tests from blocking the merge queue
([#496](#496)).
* Support more than one dashboard per step
([#472](#472)).
* Update databricks-sdk requirement from ~=0.11.0 to ~=0.12.0
([#505](#505)).
* Update databricks-sdk requirement from ~=0.12.0 to ~=0.13.0
([#575](#575)).
pritishpai pushed a commit that referenced this pull request Nov 21, 2023
@nfx @pritishpai
Release v0.6.0 (#598)
301a4e3 
**Breaking changes** (existing installations need to reinstall UCX and
re-run assessment jobs)

* Switched local group migration component to rename groups instead of
creating backup groups
([#450](#450)).
* Mitigate permissions loss in Table ACLs by folding grants belonging to
the same principal, object id and object type together
([#512](#512)).

**New features**

* Added support for the experimental Databricks CLI launcher
([#517](#517)).
* Added support for external Hive Metastores including AWS Glue
([#400](#400)).
* Added more views to assessment dashboard
([#474](#474)).
* Added rate limit for creating backup group to increase stability
([#500](#500)).
* Added deduplication for mount point list
([#569](#569)).
* Added documentation to describe interaction with external Hive
Metastores ([#473](#473)).
* Added failure injection for job failure message propagation
([#591](#591)).
* Added uniqueness in the new warehouse name to avoid conflicts on
installation ([#542](#542)).
* Added a global init script to collect Hive Metastore lineage
([#513](#513)).
* Added retry set/update permissions when possible and assess the
changes in the workspace
([#519](#519)).
* Use `~/.ucx/state.json` to store the state of both dashboards and jobs
([#561](#561)).

**Bug fixes**

* Fixed handling for `OWN` table permissions
([#571](#571)).
* Fixed handling of keys with and without values.
([#514](#514)).
* Fixed integration test failures related to concurrent group delete
([#584](#584)).
* Fixed issue with workspace listing process on None type `object_type`
([#481](#481)).
* Fixed missing group entitlement migration bug
([#583](#583)).
* Fixed entitlement application for account-level groups
([#529](#529)).
* Fixed assessment throwing an error when the owner of an object is
empty ([#485](#485)).
* Fixed installer to migrate between different configuration file
versions ([#596](#596)).
* Fixed cluster policy crawler to be aware of deleted policies
([#486](#486)).
* Improved error message for not null constraints violated
([#532](#532)).
* Improved integration test resiliency
([#597](#597),
[#594](#594),
[#586](#586)).
* Introduced Safer access to workspace objects' properties.
([#530](#530)).
* Mitigated permissions loss in Table ACLs by running appliers with
single thread ([#518](#518)).
* Running apply permission task before assessment should display message
([#487](#487)).
* Split integration tests from blocking the merge queue
([#496](#496)).
* Support more than one dashboard per step
([#472](#472)).
* Update databricks-sdk requirement from ~=0.11.0 to ~=0.12.0
([#505](#505)).
* Update databricks-sdk requirement from ~=0.12.0 to ~=0.13.0
([#575](#575)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nfx nfx nfx approved these changes

+1 more reviewer

@mwojtyczka mwojtyczka mwojtyczka approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add retry to redash permissions

3 participants

@tnguyen-db @nfx @mwojtyczka