Fix/secret scope getresponse by dipankarkush-db · Pull Request #431 · databrickslabs/ucx

dipankarkush-db · 2023-10-10T23:09:16Z

fix for #430

Fixes #428

Fixes #430

codecov · 2023-10-10T23:11:33Z

Codecov Report

Merging #431 (51d2ea9) into main (1d9219c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #431   +/-   ##
=======================================
  Coverage   84.45%   84.45%           
=======================================
  Files          31       31           
  Lines        2850     2850           
  Branches      539      539           
=======================================
  Hits         2407     2407           
  Misses        323      323           
  Partials      120      120

Files	Coverage Δ
src/databricks/labs/ucx/assessment/crawlers.py	`85.11% <100.00%> (ø)`

nfx · 2023-10-10T23:37:06Z

Make fmt

dipankarkush-db · 2023-10-10T23:38:02Z

Make fmt

Yes not ready for review yet. adding few test cases. will let you know.

Fixes #430

gitguardian · 2023-10-11T01:37:53Z

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
8442612	Generic High Entropy Secret	`feb9af5`	tests/unit/assessment/test_assessment.py	View secret
8442612	Generic High Entropy Secret	`fa2eb28`	tests/unit/assessment/test_assessment.py	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

Fixes #430

…to fix/secret-scope-getresponse

larsgeorge-db · 2023-10-11T08:27:44Z

I trust you saw the GitGuardian messages above and using the hardcoded value is what you intended. They seem to be only used for mocking the response, so I guess this is OK.

# Version changelog ## 0.4.0 * Added exception handling for secret scope not found. ([#418](#418)). * Added a crawler for creating an inventory of Azure Service Principals ([#326](#326)). * Added check if account group already exists during failure recovery ([#446](#446)). * Added checking for index out of range. ([#429](#429)). * Added hyperlink to UCX releases in the main readme ([#408](#408)). * Added integration test to check backup groups get deleted ([#387](#387)). * Added logging of errors during threadpool operations. ([#376](#376)). * Added recovery mode for workspace-local groups from temporary groups ([#435](#435)). * Added support for migrating Legacy Table ACLs from workspace-local to account-level groups ([#412](#412)). * Added detection for installations of unreleased versions ([#399](#399)). * Decoupled `PermissionsManager` from `GroupMigrationToolkit` ([#407](#407)). * Enabled debug logging for every job task run through a file, which is accessible from both workspace UI and Databricks CLI ([#426](#426)). * Ensured that table exists, even when crawlers produce zero records ([#373](#373)). * Extended test suite for HMS->HMS TACL migration ([#439](#439)). * Fixed handling of secret scope responses ([#431](#431)). * Fixed `crawl_permissions` task to respect 'workspace_start_path' config ([#444](#444)). * Fixed broken logic in `parallel` module and applied hardened error handling design for parallel code ([#405](#405)). * Fixed codecov.io reporting ([#403](#403)). * Fixed integration tests for crawlers ([#379](#379)). * Improved README.py and logging messages ([#433](#433)). * Improved cleanup for workspace backup groups by adding more retries on errors ([#375](#375)). * Improved dashboard queries to show unsupported storage types. ([#398](#398)). * Improved documentation for readme notebook ([#257](#257)). * Improved test coverage for installer ([#371](#371)). * Introduced deterministic `env_or_skip` fixture for integration tests ([#396](#396)). * Made HMS & UC fixtures return `CatalogInfo`, `SchemaInfo`, and `TableInfo` ([#409](#409)). * Merge `workspace_access.Crawler` and `workspace_access.Applier` interfaces to `workspace_access.AclSupport` ([#436](#436)). * Moved examples to docs ([#404](#404)). * Properly isolated integration testing for workflows on an existing shared cluster ([#414](#414)). * Removed thread pool for any IAM Group removals and additions ([#394](#394)). * Replace plus char with minus in version tag for GCP dev installation of UCX ([#420](#420)). * Run integration tests on shared clusters for a faster devloop ([#397](#397)). * Show difference between serverless and PRO warehouses during installation ([#385](#385)). * Split `migrate-groups` workflow into three different stages for reliability ([#442](#442)). * Use groups instead of usernames in code owners file ([#389](#389)).

fix for #430

# Version changelog ## 0.4.0 * Added exception handling for secret scope not found. ([#418](#418)). * Added a crawler for creating an inventory of Azure Service Principals ([#326](#326)). * Added check if account group already exists during failure recovery ([#446](#446)). * Added checking for index out of range. ([#429](#429)). * Added hyperlink to UCX releases in the main readme ([#408](#408)). * Added integration test to check backup groups get deleted ([#387](#387)). * Added logging of errors during threadpool operations. ([#376](#376)). * Added recovery mode for workspace-local groups from temporary groups ([#435](#435)). * Added support for migrating Legacy Table ACLs from workspace-local to account-level groups ([#412](#412)). * Added detection for installations of unreleased versions ([#399](#399)). * Decoupled `PermissionsManager` from `GroupMigrationToolkit` ([#407](#407)). * Enabled debug logging for every job task run through a file, which is accessible from both workspace UI and Databricks CLI ([#426](#426)). * Ensured that table exists, even when crawlers produce zero records ([#373](#373)). * Extended test suite for HMS->HMS TACL migration ([#439](#439)). * Fixed handling of secret scope responses ([#431](#431)). * Fixed `crawl_permissions` task to respect 'workspace_start_path' config ([#444](#444)). * Fixed broken logic in `parallel` module and applied hardened error handling design for parallel code ([#405](#405)). * Fixed codecov.io reporting ([#403](#403)). * Fixed integration tests for crawlers ([#379](#379)). * Improved README.py and logging messages ([#433](#433)). * Improved cleanup for workspace backup groups by adding more retries on errors ([#375](#375)). * Improved dashboard queries to show unsupported storage types. ([#398](#398)). * Improved documentation for readme notebook ([#257](#257)). * Improved test coverage for installer ([#371](#371)). * Introduced deterministic `env_or_skip` fixture for integration tests ([#396](#396)). * Made HMS & UC fixtures return `CatalogInfo`, `SchemaInfo`, and `TableInfo` ([#409](#409)). * Merge `workspace_access.Crawler` and `workspace_access.Applier` interfaces to `workspace_access.AclSupport` ([#436](#436)). * Moved examples to docs ([#404](#404)). * Properly isolated integration testing for workflows on an existing shared cluster ([#414](#414)). * Removed thread pool for any IAM Group removals and additions ([#394](#394)). * Replace plus char with minus in version tag for GCP dev installation of UCX ([#420](#420)). * Run integration tests on shared clusters for a faster devloop ([#397](#397)). * Show difference between serverless and PRO warehouses during installation ([#385](#385)). * Split `migrate-groups` workflow into three different stages for reliability ([#442](#442)). * Use groups instead of usernames in code owners file ([#389](#389)).

dipankarkush-db added 6 commits October 10, 2023 17:08

Added checking for index out of range.

0185dc6

Fixes #428

Added checking for index out of range.

470838f

Fixes #428

Added checking for index out of range.

c6bf2b2

Fixes #428

Added checking for index out of range.

627fa25

Fixes #428

Added checking for index out of range.

3605ca6

Fixes #428

Added checking for index out of range.

2afc73a

Fixes #430

nfx approved these changes Oct 10, 2023

View reviewed changes

dipankarkush-db added 2 commits October 10, 2023 21:15

Added checking for index out of range.

1c2f715

Fixes #430

Added checking for index out of range.

feb9af5

Fixes #430

dipankarkush-db added 3 commits October 10, 2023 21:41

Added checking for index out of range.

fa2eb28

Fixes #430

Added fix for secret scope getresponse.

e714274

Fixes #430

Merge remote-tracking branch 'origin/fix/secret-scope-getresponse' in…

51d2ea9

…to fix/secret-scope-getresponse

dipankarkush-db marked this pull request as ready for review October 11, 2023 01:47

dipankarkush-db requested review from a team October 11, 2023 01:47

larsgeorge-db approved these changes Oct 11, 2023

View reviewed changes

larsgeorge-db added this pull request to the merge queue Oct 11, 2023

Merged via the queue into main with commit 93d8f0f Oct 11, 2023

nfx mentioned this pull request Oct 12, 2023

Release v0.4.0 #447

Merged

nfx linked an issue Oct 16, 2023 that may be closed by this pull request

TypeError: unhashable type: 'GetSecretResponse' while querying secret #430

Closed

nfx deleted the fix/secret-scope-getresponse branch October 17, 2023 22:44

FastLee pushed a commit that referenced this pull request Oct 25, 2023

Fix/secret scope getresponse (#431)

018fad7

fix for #430

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/secret scope getresponse#431

Fix/secret scope getresponse#431
larsgeorge-db merged 11 commits intomainfrom
fix/secret-scope-getresponse

dipankarkush-db commented Oct 10, 2023

Uh oh!

codecov bot commented Oct 10, 2023 •

edited

Loading

Uh oh!

nfx commented Oct 10, 2023

Uh oh!

dipankarkush-db commented Oct 10, 2023

Uh oh!

gitguardian bot commented Oct 11, 2023 •

edited

Loading

Uh oh!

larsgeorge-db commented Oct 11, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dipankarkush-db commented Oct 10, 2023

Uh oh!

codecov bot commented Oct 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nfx commented Oct 10, 2023

Uh oh!

dipankarkush-db commented Oct 10, 2023

Uh oh!

gitguardian bot commented Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Uh oh!

larsgeorge-db commented Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Oct 10, 2023 •

edited

Loading

gitguardian bot commented Oct 11, 2023 •

edited

Loading

larsgeorge-db commented Oct 11, 2023 •

edited

Loading