Skip to content

Skip group migration when no groups are available after preparation step.#363

Merged
nfx merged 2 commits intomainfrom
fix/issue_360_skip_empty_groups
Oct 3, 2023
Merged

Skip group migration when no groups are available after preparation step.#363
nfx merged 2 commits intomainfrom
fix/issue_360_skip_empty_groups

Conversation

@larsgeorge-db
Copy link
Copy Markdown
Contributor

Fixes #360

@larsgeorge-db larsgeorge-db requested a review from nfx as a code owner October 3, 2023 11:57
@larsgeorge-db larsgeorge-db self-assigned this Oct 3, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 3, 2023

Codecov Report

Merging #363 (c2be2f9) into main (f3886f7) will decrease coverage by 0.12%.
Report is 1 commits behind head on main.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   83.58%   83.47%   -0.12%     
==========================================
  Files          30       30              
  Lines        2254     2269      +15     
  Branches      394      395       +1     
==========================================
+ Hits         1884     1894      +10     
- Misses        285      290       +5     
  Partials       85       85              
Files Coverage Δ
src/databricks/labs/ucx/workspace_access/groups.py 93.12% <100.00%> (+0.10%) ⬆️
.../databricks/labs/ucx/workspace_access/migration.py 47.76% <50.00%> (+0.06%) ⬆️
src/databricks/labs/ucx/runtime.py 54.79% <0.00%> (-1.55%) ⬇️

... and 1 file with indirect coverage changes

@nfx nfx added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit 035320c Oct 3, 2023
zpappa pushed a commit that referenced this pull request Oct 3, 2023
nfx added a commit that referenced this pull request Oct 3, 2023
* Added `inventory_database` name check during installation ([#275](#275)).
* Added a column to `$inventory.tables` to specify if a table might have been synchronised to Unity Catalog already or not ([#306](#306)).
* Added a migration state to skip already migrated tables ([#325](#325)).
* Fixed appending to tables by adding filtering of `None` rows ([#356](#356)).
* Fixed handling of missing but linked cluster policies. ([#361](#361)).
* Ignore errors for Redash widgets and queries redeployment during installation ([#367](#367)).
* Remove exception and added proper logging for groups in the list that… ([#357](#357)).
* Skip group migration when no groups are available after preparation step. ([#363](#363)).
* Update databricks-sdk requirement from ~=0.9.0 to ~=0.10.0 ([#362](#362)).
@nfx nfx mentioned this pull request Oct 3, 2023
nfx added a commit that referenced this pull request Oct 3, 2023
* Added `inventory_database` name check during installation
([#275](#275)).
* Added a column to `$inventory.tables` to specify if a table might have
been synchronised to Unity Catalog already or not
([#306](#306)).
* Added a migration state to skip already migrated tables
([#325](#325)).
* Fixed appending to tables by adding filtering of `None` rows
([#356](#356)).
* Fixed handling of missing but linked cluster policies.
([#361](#361)).
* Ignore errors for Redash widgets and queries redeployment during
installation ([#367](#367)).
* Remove exception and added proper logging for groups in the list that…
([#357](#357)).
* Skip group migration when no groups are available after preparation
step. ([#363](#363)).
* Update databricks-sdk requirement from ~=0.9.0 to ~=0.10.0
([#362](#362)).
zpappa pushed a commit that referenced this pull request Oct 4, 2023
* Added `inventory_database` name check during installation
([#275](#275)).
* Added a column to `$inventory.tables` to specify if a table might have
been synchronised to Unity Catalog already or not
([#306](#306)).
* Added a migration state to skip already migrated tables
([#325](#325)).
* Fixed appending to tables by adding filtering of `None` rows
([#356](#356)).
* Fixed handling of missing but linked cluster policies.
([#361](#361)).
* Ignore errors for Redash widgets and queries redeployment during
installation ([#367](#367)).
* Remove exception and added proper logging for groups in the list that…
([#357](#357)).
* Skip group migration when no groups are available after preparation
step. ([#363](#363)).
* Update databricks-sdk requirement from ~=0.9.0 to ~=0.10.0
([#362](#362)).
@nfx nfx deleted the fix/issue_360_skip_empty_groups branch October 17, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

The tool fails if there are no groups to migrate

2 participants