Add dummy id for jobs to include on MockInstallationContext.config#3499
Merged
JCZuurmond merged 1 commit intomainfrom Jan 8, 2025
Merged
Conversation
JCZuurmond
added
internal
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
|
✅ 2/2 passed, 1m19s total Running from acceptance #7907 |
JCZuurmond
force-pushed
the
fix/create-at-least-one-job-on-mock-installation-context
branch
from
bf1891d to
bef0f12
Compare
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
asnare
approved these changes
Jan 8, 2025
Contributor
asnare
left a comment
asnare
left a comment
There was a problem hiding this comment.
Agree, this isn't ideal but glad to see the underlying cause is being addressed upstream in databrickslabs/blueprint#180 (after which this can be removed).
JCZuurmond
force-pushed
the
fix/create-at-least-one-job-on-mock-installation-context
branch
from
bef0f12 to
113f1b7
Compare
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
JCZuurmond
deleted the
fix/create-at-least-one-job-on-mock-installation-context
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add dummy id for jobs to include on
MockInstallationContext.configto avoid assessing all workflows.Linked issues
A more proper solution would be to resolve: databrickslabs/blueprint#179
Tests