Fix failing test test_job_task_linter_library_not_installed_cluster#2867
Merged
Fix failing test test_job_task_linter_library_not_installed_cluster#2867
Conversation
ericvergnaud
had a problem deploying
to
account-admin
GitHub Actions
Error
ericvergnaud
had a problem deploying
to
account-admin
GitHub Actions
Failure
|
❌ 41/42 passed, 1 failed, 27m51s total ❌ test_job_dlt_task_linter_unhappy_path: assert 0 == 1 (12.776s)Running from acceptance #6495 |
1 task
nfx
pushed a commit
that referenced
this pull request
Oct 9, 2024
…2853) ## Changes This PR updates some linting related integration tests that weren't testing what they expected: - The tests were intending to verify linting of notebooks, and set up a notebook with code to trigger a linting record. - The linting code was failing prematurely due to the notebook extension, not due to the problem in source. Some usage of `greenlet` has also been replaced: it was previously unknown to the linter and various integration tests assumed this. Since #2830 these tests have no longer been working correctly. ### Related Issues Overlaps with #2852. Overlaps with #2867. Overlaps with #2868. Resolves #2843. Resolves #2844. Resolves #2845. Resolves #2846. ### Tests - [X] updated integration tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Use genuinely unknown library
Linked issues
None
Functionality
None
Tests