Add inventory_database name check#275
Merged
nfx merged 6 commits intodatabrickslabs:mainfrom Oct 3, 2023
dmoore247:fix-inventory-database-name
Merged
Add inventory_database name check#275nfx merged 6 commits intodatabrickslabs:mainfrom dmoore247:fix-inventory-database-name
nfx merged 6 commits intodatabrickslabs:mainfrom
dmoore247:fix-inventory-database-name
Conversation
Codecov Report
@@ Coverage Diff @@
## main #275 +/- ##
==========================================
- Coverage 83.47% 83.21% -0.26%
==========================================
Files 30 30
Lines 2269 2318 +49
Branches 395 411 +16
==========================================
+ Hits 1894 1929 +35
- Misses 290 300 +10
- Partials 85 89 +4
|
nfx
requested changes
Sep 22, 2023
|
|
||
| logger.info("Please answer a couple of questions to configure Unity Catalog migration") | ||
| inventory_database = self._question("Inventory Database", default="ucx") | ||
| while True: |
Collaborator
There was a problem hiding this comment.
Can you refactor this into a method and do max 10 attempts to ask for a valid database?
Contributor
Author
|
Working on feedback, waiting for assessment job before re-testing installer. |
Collaborator
|
@dmoore247 you know you can kill installer by CTRL+C (or CMD+D, don't remember), right?.. |
Collaborator
|
@dmoore247 any update? |
Contributor
larsgeorge-db
left a comment
larsgeorge-db
left a comment
There was a problem hiding this comment.
Not to say this is not useful, but this should also then be done for most of the other inputs, no? And even then, you can always edit the config file in the workspace afterwards.
Contributor
Author
|
I think I can get to it next week. |
Collaborator
|
Following up - is this issue still relevant? |
nfx
requested changes
Oct 3, 2023
Collaborator
nfx
left a comment
nfx
left a comment
There was a problem hiding this comment.
remove install in the root, otherwise lgtm
dmoore247
commented
Oct 3, 2023
Contributor
Author
dmoore247
left a comment
dmoore247
left a comment
There was a problem hiding this comment.
removed install file
nfx
approved these changes
Oct 3, 2023
nfx
added a commit
that referenced
this pull request
Oct 3, 2023
* Added `inventory_database` name check during installation ([#275](#275)). * Added a column to `$inventory.tables` to specify if a table might have been synchronised to Unity Catalog already or not ([#306](#306)). * Added a migration state to skip already migrated tables ([#325](#325)). * Fixed appending to tables by adding filtering of `None` rows ([#356](#356)). * Fixed handling of missing but linked cluster policies. ([#361](#361)). * Ignore errors for Redash widgets and queries redeployment during installation ([#367](#367)). * Remove exception and added proper logging for groups in the list that… ([#357](#357)). * Skip group migration when no groups are available after preparation step. ([#363](#363)). * Update databricks-sdk requirement from ~=0.9.0 to ~=0.10.0 ([#362](#362)).
Merged
nfx
added a commit
that referenced
this pull request
Oct 3, 2023
* Added `inventory_database` name check during installation ([#275](#275)). * Added a column to `$inventory.tables` to specify if a table might have been synchronised to Unity Catalog already or not ([#306](#306)). * Added a migration state to skip already migrated tables ([#325](#325)). * Fixed appending to tables by adding filtering of `None` rows ([#356](#356)). * Fixed handling of missing but linked cluster policies. ([#361](#361)). * Ignore errors for Redash widgets and queries redeployment during installation ([#367](#367)). * Remove exception and added proper logging for groups in the list that… ([#357](#357)). * Skip group migration when no groups are available after preparation step. ([#363](#363)). * Update databricks-sdk requirement from ~=0.9.0 to ~=0.10.0 ([#362](#362)).
zpappa
pushed a commit
that referenced
this pull request
Oct 4, 2023
Check that database name is a word, loop until correct.
zpappa
pushed a commit
that referenced
this pull request
Oct 4, 2023
* Added `inventory_database` name check during installation ([#275](#275)). * Added a column to `$inventory.tables` to specify if a table might have been synchronised to Unity Catalog already or not ([#306](#306)). * Added a migration state to skip already migrated tables ([#325](#325)). * Fixed appending to tables by adding filtering of `None` rows ([#356](#356)). * Fixed handling of missing but linked cluster policies. ([#361](#361)). * Ignore errors for Redash widgets and queries redeployment during installation ([#367](#367)). * Remove exception and added proper logging for groups in the list that… ([#357](#357)). * Skip group migration when no groups are available after preparation step. ([#363](#363)). * Update databricks-sdk requirement from ~=0.9.0 to ~=0.10.0 ([#362](#362)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check that database name is a word, loop until correct.