Skip to content

Bugfix: test_delete_ws_groups_should_delete_renamed_and_reflected_groups_only#2541

Merged
nfx merged 1 commit intomainfrom
bug/get-group-not-found-check
Sep 5, 2024
Merged

Bugfix: test_delete_ws_groups_should_delete_renamed_and_reflected_groups_only#2541
nfx merged 1 commit intomainfrom
bug/get-group-not-found-check

Conversation

@asnare
Copy link
Copy Markdown
Contributor

@asnare asnare commented Sep 5, 2024

Changes

This PR updates an integration test that started failing after the Databricks 0.32.0 release. In this test we check the error message associated with an expected failure, but the message changed with the new version of the SDK so the test now fails.

Note: This is probably a bug introduced in the upstream SDK release. For a call to ws.groups.get(id) where the ID doesn't exist:

  • Previously we would get the message: Group with id $ID not found.
  • As of the new release we get: None request failed

Linked issues

Resolves #2539.

Tests

  • updated integration test

The 0.32.0 release of the Databricks SDK has changed the message attached to the error (probably a bug) which causes this test to (incorrectly) fail.
@asnare asnare added bug internal this pull request won't appear in release notes labels Sep 5, 2024
@asnare asnare self-assigned this Sep 5, 2024
@asnare asnare requested review from a team and dipankarkush-db September 5, 2024 15:47
Copy link
Copy Markdown
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx merged commit 668fcce into main Sep 5, 2024
@nfx nfx deleted the bug/get-group-not-found-check branch September 5, 2024 15:49
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 5, 2024

✅ 104/104 passed, 1 skipped, 1h43m5s total

Running from acceptance #5559

nfx pushed a commit that referenced this pull request Sep 10, 2024
## Changes

This PR updates an integration test that has started failing since the
Databricks 0.32.0 release. In this test we check the error message
associated with an expected failure, but the message changed with the
new version of the SDK so the test now fails.

### Linked issues

Relates to #2541, affects #2546.

Resolves #2538.

Triggered by upstream databricks/databricks-sdk-py#749.

### Tests

- updated integration test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal this pull request won't appear in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure: test_delete_ws_groups_should_delete_renamed_and_reflected_groups_only

2 participants