Skip to content

register child notebooks from magic lines in dependency-graph#2164

Merged
nfx merged 1 commit intoinfer-values-from-child-notebook-in-magic-linefrom
add-child-notebooks-from-magic-lines-to-dependency-graph
Jul 11, 2024
Merged

register child notebooks from magic lines in dependency-graph#2164
nfx merged 1 commit intoinfer-values-from-child-notebook-in-magic-linefrom
add-child-notebooks-from-magic-lines-to-dependency-graph

Conversation

@ericvergnaud
Copy link
Copy Markdown
Contributor

Changes

register child notebooks from magic lines in dependency-graph

Linked issues

Progresses #2155

Functionality

None

Tests

  • added unit tests

@ericvergnaud ericvergnaud requested review from a team and vsevolodstep-db and removed request for a team July 11, 2024 18:07
@github-actions
Copy link
Copy Markdown

✅ 26/26 passed, 1 skipped, 10m8s total

Running from acceptance #4640

Copy link
Copy Markdown
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx merged commit 816c12c into infer-values-from-child-notebook-in-magic-line Jul 11, 2024
@nfx nfx deleted the add-child-notebooks-from-magic-lines-to-dependency-graph branch July 11, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants