Resolve relative paths when building dependency graph#1593
Closed
ericvergnaud wants to merge 31 commits intomainfrom
Closed
Resolve relative paths when building dependency graph#1593ericvergnaud wants to merge 31 commits intomainfrom
ericvergnaud wants to merge 31 commits intomainfrom
Conversation
…m/ericvergnaud/ucx into use-stack-of-dependency-resolvers * 'use-stack-of-dependency-resolvers' of https://github.com/ericvergnaud/ucx: cherry-pick from old branch cherry-pick from old branch split dependencies.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1593 +/- ##
==========================================
+ Coverage 89.35% 89.48% +0.13%
==========================================
Files 80 83 +3
Lines 10014 10208 +194
Branches 1786 1804 +18
==========================================
+ Hits 8948 9135 +187
- Misses 696 700 +4
- Partials 370 373 +3 ☔ View full report in Codecov by Sentry. |
ericvergnaud
had a problem deploying
to
account-admin
GitHub Actions
Failure
nfx
requested changes
May 2, 2024
Collaborator
nfx
left a comment
nfx
left a comment
There was a problem hiding this comment.
I've moved classes around to have more consistency with the rest of the codebase, placement clarity, and avoid cyclic imports. It may make sense to reapply this PR from scratch.
11 tasks
Contributor
Author
|
replaced by #1608 |
nfx
pushed a commit
that referenced
this pull request
May 3, 2024
## Changes Add support for cwd to SysPathProvider Implement LocalNotebookLoader Provide tests for local files and folders ### Linked issues #1202 Resolves #1499 Resolves #1287 replaces #1593 --------- Co-authored-by: Eric Vergnaud <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nfx can be reviewed but depends on #1560
Changes
Add support for cwd to SysPathProvider
Implement LocalNotebookLoader
Provide tests for local files and folders
Linked issues
#1202
Resolves #1499
Resolves #1287
Functionality
databricks labs ucx .........Tests