Conversation
JCZuurmond
approved these changes
Apr 18, 2024
JCZuurmond
reviewed
Apr 18, 2024
| src_schema = runtime_ctx.make_schema(catalog_name="hive_metastore") | ||
| # make a copy of src data to a new location to avoid overlapping UC table path that will fail other | ||
| # external table migration tests | ||
| existing_mounted_location, new_mounted_location = make_mounted_location() |
Contributor
There was a problem hiding this comment.
@nkvuong : Maybe this fixture should be renamed as nothing is "maken", it returns a tuple with the mounted locations
Contributor
Author
There was a problem hiding this comment.
just refactored it :)
11 tasks
nkvuong
changed the title
test_migrate_external_table
JCZuurmond
reviewed
Apr 18, 2024
JCZuurmond
approved these changes
Apr 18, 2024
Contributor
JCZuurmond
left a comment
JCZuurmond
left a comment
There was a problem hiding this comment.
LGTM, request to clarify with comment only
nkvuong
force-pushed
the
fix/integration-tests
branch
from
bd2b947 to
64abc65
Compare
nkvuong
force-pushed
the
fix/integration-tests
branch
from
eace4bb to
ecc2880
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
TypeError: 'tuple' object is not callablefortest_migrate_external_tableparse_logs, by skipping over these error messages if ucx version is testingLinked issues
Resolves #1436, #1424
Tests