disable annotation-unchecked mypy warning#1331
Merged
nfx merged 1 commit intodatabrickslabs:mainfrom Apr 8, 2024
Merged
Conversation
ericvergnaud
had a problem deploying
to
account-admin
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1331 +/- ##
==========================================
- Coverage 90.02% 90.01% -0.01%
==========================================
Files 62 63 +1
Lines 7430 8026 +596
Branches 1335 1425 +90
==========================================
+ Hits 6689 7225 +536
- Misses 470 514 +44
- Partials 271 287 +16 ☔ View full report in Codecov by Sentry. |
ericvergnaud
added a commit
to ericvergnaud/ucx
that referenced
this pull request
Apr 9, 2024
* main: Adding CSV, JSON and include path in mounts (databrickslabs#1329) Add missing step sync-workspace-info (databrickslabs#1330) disable annotation-unchecked mypy warning (databrickslabs#1331) Use service factory to resolve object dependencies (databrickslabs#1209)
ericvergnaud
added a commit
to ericvergnaud/ucx
that referenced
this pull request
Apr 9, 2024
…f-notebook-dependencies * detect-dbutils.notebook.run: address code review comments move PythonLinter to python_linter file renamed from astlinter change model to avoid clashing ownership patterns address code review comments Adding CSV, JSON and include path in mounts (databrickslabs#1329) Add missing step sync-workspace-info (databrickslabs#1330) disable annotation-unchecked mypy warning (databrickslabs#1331) Use service factory to resolve object dependencies (databrickslabs#1209) # Conflicts: # src/databricks/labs/ucx/source_code/notebook.py # tests/unit/source_code/test_notebook.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Changes mypy config
Linked issues
None
Functionality
databricks labs ucx .........Tests