Merged
Conversation
ericvergnaud
had a problem deploying
to
account-admin
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1280 +/- ##
==========================================
+ Coverage 90.02% 90.15% +0.12%
==========================================
Files 62 62
Lines 7430 7782 +352
Branches 1335 1400 +65
==========================================
+ Hits 6689 7016 +327
- Misses 470 487 +17
- Partials 271 279 +8 ☔ View full report in Codecov by Sentry. |
ericvergnaud
added a commit
to ericvergnaud/ucx
that referenced
this pull request
Apr 5, 2024
* main: remove `isort` (databrickslabs#1280) Addressed Issue with Disabled Feature in certain regions (databrickslabs#1275) Improve documentation (databrickslabs#1162) Add roadmap workflows and tasks to Table Migration Workflow document (databrickslabs#1274) Fix integration test with new DeployedWorkflows (databrickslabs#1250) Document troubleshooting guide (databrickslabs#1226) Split `DeployedWorkflows` out of `WorkflowsDeployment` (databrickslabs#1248) Inject `_TASKS` via constructor to `WorkflowsDeployment` instead of a global variable (databrickslabs#1247) Decouple `InstallState` from `WorkspaceDeployment` constructor Add document for table migration workflow (databrickslabs#1229) Decouple `InstallState` from `WorkflowsDeployment` constructor (databrickslabs#1246)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isortandpylintdisagree on import order with:the solution is to remove
isortfrom themake fmtbuild commandChanges
remove sort from build checks
Linked issues
None
Functionality
databricks labs ucx .........Tests