Fix assessment.md table of contents for the 300 series findings#1162
Merged
Fix assessment.md table of contents for the 300 series findings#1162
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1162 +/- ##
==========================================
+ Coverage 89.75% 89.80% +0.04%
==========================================
Files 60 61 +1
Lines 7235 7246 +11
Branches 1299 1299
==========================================
+ Hits 6494 6507 +13
+ Misses 477 475 -2
Partials 264 264 ☔ View full report in Codecov by Sentry. |
|
❌ 136/138 passed, 2 failed, 20 skipped, 2h15m4s total ❌ test_delete_ws_groups_should_delete_renamed_and_reflected_groups_only: Failed: DID NOT RAISE (22.95s)❌ test_replace_workspace_groups_with_account_groups: TimeoutError: Timed out after 0:03:00 (3m52.489s)Running from acceptance #2008 |
nfx
requested changes
Mar 29, 2024
docs/assessment.md
Outdated
| - [AF301.1 - spark.catalog.x](#af3011---sparkcatalogx) | ||
| - [AF301.2 - spark.catalog.x](#af3012---sparkcatalogx) | ||
| - [AF302.x - Arbitrary Java](#af302x---arbitrary-java) | ||
| - [AF302.1 - Arbitrary Java](#af3021---arbitrary-java) |
Collaborator
There was a problem hiding this comment.
Duplicate heading names make no sense for the user. Rewrite all headings to be unique and don't look like a copy-paste
ericvergnaud
added a commit
to ericvergnaud/ucx
that referenced
this pull request
Apr 5, 2024
* main: remove `isort` (databrickslabs#1280) Addressed Issue with Disabled Feature in certain regions (databrickslabs#1275) Improve documentation (databrickslabs#1162) Add roadmap workflows and tasks to Table Migration Workflow document (databrickslabs#1274) Fix integration test with new DeployedWorkflows (databrickslabs#1250) Document troubleshooting guide (databrickslabs#1226) Split `DeployedWorkflows` out of `WorkflowsDeployment` (databrickslabs#1248) Inject `_TASKS` via constructor to `WorkflowsDeployment` instead of a global variable (databrickslabs#1247) Decouple `InstallState` from `WorkspaceDeployment` constructor Add document for table migration workflow (databrickslabs#1229) Decouple `InstallState` from `WorkflowsDeployment` constructor (databrickslabs#1246)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix assessment.md table of contents for the 300 series findings
Linked issues
Resolves #..
Functionality
databricks labs ucx .........Tests
Tested in github browser.