Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1048 +/- ##
==========================================
- Coverage 88.65% 88.64% -0.02%
==========================================
Files 52 52
Lines 6655 6655
Branches 1194 1194
==========================================
- Hits 5900 5899 -1
- Misses 498 500 +2
+ Partials 257 256 -1 ☔ View full report in Codecov by Sentry. |
11 tasks
dmoore247
pushed a commit
that referenced
this pull request
Mar 23, 2024
## Changes - Fixed `test_get_existing_installation_global` which is leaky - Fixed `test_jobs_assessment_with_spn_cluster_no_job_tasks` which was wrong & previously skipped ### Tests <!-- How is this tested? Please see the checklist below and also describe any other relevant tests --> - [x] manually tested - [x] added unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
test_get_existing_installation_globalwhich is leakytest_jobs_assessment_with_spn_cluster_no_job_taskswhich was wrong & previously skippedTests