-
Notifications
You must be signed in to change notification settings - Fork 101
[FEATURE]: Convert relative paths to full paths when building notebook dependency graph #1287
Copy link
Copy link
Closed
Labels
good first issueGood for newcomersGood for newcomersmigrate/codeAbstract Syntax Trees and other dark magicAbstract Syntax Trees and other dark magicmigrate/pythonPull requests that update Python codePull requests that update Python codetech debtchores and design flawschores and design flaws
Description
Is there an existing issue for this?
- I have searched the existing issues
Problem statement
Commands such as %run ./some_notebook refer to a notebook path that can be relative to the currently executing notebook.
Depending on where from the above command is invoked, the notebook path for the same notebook could vary significantly.
We need to support this variation of notebook paths when building the dependency graph
Proposed Solution
The DependencyGraph already accepts a locator function.
The locator used for unit testing only deals with local samples in the same folder.
This production locator should be context aware and convert relative paths to full paths, such that we only traverse notebooks once.
Additional Context
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomersmigrate/codeAbstract Syntax Trees and other dark magicAbstract Syntax Trees and other dark magicmigrate/pythonPull requests that update Python codePull requests that update Python codetech debtchores and design flawschores and design flaws
Type
Projects
Status
No status