Drop the path attribute the graph.

asnare · asnare · commit 5993eea3df10 · 2024-08-02T15:49:46.000+02:00
We have 20 public methods (the pylint limit), and are about to introduce another. This property is the easiest to eliminate.
diff --git a/src/databricks/labs/ucx/source_code/graph.py b/src/databricks/labs/ucx/source_code/graph.py
@@ -41,10 +41,6 @@ def path_lookup(self):
     def dependency(self):
         return self._dependency
 
-    @property
-    def path(self):
-        return self._dependency.path
-
     def register_library(self, *libraries: str) -> list[DependencyProblem]:
         return self._resolver.register_library(self.path_lookup, *libraries)
 
@@ -97,7 +93,7 @@ def locate_dependency(self, path: Path) -> MaybeGraph:
         found: list[DependencyGraph] = []
 
         def check_registered_dependency(graph):
-            if graph.path == path:
+            if graph.dependency.path == path:
                 found.append(graph)
                 return True
             return False
@@ -201,9 +197,10 @@ def root_relative_names(self) -> set[str]:
     def visit(self, visit_node: Callable[[DependencyGraph], bool | None], visited: set[Path] | None) -> bool:
         """provide visited set if you want to ensure nodes are only visited once"""
         if visited is not None:
-            if self.path in visited:
+            path = self.dependency.path
+            if path in visited:
                 return False
-            visited.add(self.path)
+            visited.add(path)
         if visit_node(self):
             return True
         for dependency in self._dependencies.values():
@@ -273,7 +270,7 @@ def _build_inherited_context(self, root: Path, leaf: Path) -> InheritedContext:
         return InheritedContext.from_route(self, self.path_lookup, route)
 
     def __repr__(self):
-        return f"<DependencyGraph {self.path}>"
+        return f"<DependencyGraph {self.dependency.path}>"
 
 
 @dataclass
