Merged
Conversation
* Fixing ovewrite integration tests ([#92](#92)). A new enhancement has been implemented for the `overwrite` feature's integration tests, addressing a concern with write operations. Two new variables, `catalog` and "schema", have been incorporated using the `env_or_skip` function. These variables are utilized in the `save_table` method, which is now invoked twice with the same table, once with the `append` and once with the `overwrite` option. The data in the table is retrieved and checked for accuracy after each call, employing the updated `Row` class with revised field names `first` and "second", formerly `name` and "id". This modification ensures the proper operation of the `overwrite` feature during integration tests and resolves any related issues. The commit message `Fixing overwrite integration tests` signifies this change.
|
✅ 20/20 passed, 2 skipped, 8m30s total Running from acceptance #65 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
overwritefeature's integration tests, addressing a concern with write operations. Two new variables,catalogand "schema", have been incorporated using theenv_or_skipfunction. These variables are utilized in thesave_tablemethod, which is now invoked twice with the same table, once with theappendand once with theoverwriteoption. The data in the table is retrieved and checked for accuracy after each call, employing the updatedRowclass with revised field namesfirstand "second", formerlynameand "id". This modification ensures the proper operation of theoverwritefeature during integration tests and resolves any related issues. The commit messageFixing overwrite integration testssignifies this change.