Skip to content

Fixing ovewrite integration tests #92

Merged
nfx merged 1 commit intomainfrom
fix_int_test
Apr 12, 2024
Merged

Fixing ovewrite integration tests #92
nfx merged 1 commit intomainfrom
fix_int_test

Conversation

@william-conti
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

✅ 20/20 passed, 2 skipped, 28m16s total

Running from acceptance #64

Copy link
Copy Markdown
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! now i won't bother you on weekends ;)

@nfx nfx merged commit 9a3517b into main Apr 12, 2024
@nfx nfx deleted the fix_int_test branch April 12, 2024 12:27
nfx added a commit that referenced this pull request Apr 12, 2024
* Fixing ovewrite integration tests ([#92](#92)). A new enhancement has been implemented for the `overwrite` feature's integration tests, addressing a concern with write operations. Two new variables, `catalog` and "schema", have been incorporated using the `env_or_skip` function. These variables are utilized in the `save_table` method, which is now invoked twice with the same table, once with the `append` and once with the `overwrite` option. The data in the table is retrieved and checked for accuracy after each call, employing the updated `Row` class with revised field names `first` and "second", formerly `name` and "id". This modification ensures the proper operation of the `overwrite` feature during integration tests and resolves any related issues. The commit message `Fixing overwrite integration tests` signifies this change.
@nfx nfx mentioned this pull request Apr 12, 2024
nfx added a commit that referenced this pull request Apr 12, 2024
* Fixing ovewrite integration tests
([#92](#92)). A new
enhancement has been implemented for the `overwrite` feature's
integration tests, addressing a concern with write operations. Two new
variables, `catalog` and "schema", have been incorporated using the
`env_or_skip` function. These variables are utilized in the `save_table`
method, which is now invoked twice with the same table, once with the
`append` and once with the `overwrite` option. The data in the table is
retrieved and checked for accuracy after each call, employing the
updated `Row` class with revised field names `first` and "second",
formerly `name` and "id". This modification ensures the proper operation
of the `overwrite` feature during integration tests and resolves any
related issues. The commit message `Fixing overwrite integration tests`
signifies this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants