Skip to content

Fixing test_deployment#77

Merged
nfx merged 1 commit intomainfrom
fix_bad_test
Mar 30, 2024
Merged

Fixing test_deployment#77
nfx merged 1 commit intomainfrom
fix_bad_test

Conversation

@william-conti
Copy link
Copy Markdown
Contributor

@william-conti william-conti commented Mar 28, 2024

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.58%. Comparing base (073c922) to head (14b1f22).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage   84.58%   84.58%           
=======================================
  Files           7        7           
  Lines         532      532           
  Branches      105      105           
=======================================
  Hits          450      450           
  Misses         50       50           
  Partials       32       32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 28, 2024

❌ 17/18 passed, 1 failed, 2 skipped, 12m25s total

❌ test_overwrite: databricks.sdk.errors.platform.BadRequest: [INSUFFICIENT_PERMISSIONS] Insufficient privileges: (717ms) 
databricks.sdk.errors.platform.BadRequest: [INSUFFICIENT_PERMISSIONS] Insufficient privileges:
User does not have permission CREATE,USAGE on database `default`.
10:02 DEBUG [databricks.sdk] Loaded from environment
10:02 DEBUG [databricks.sdk] Ignoring pat auth, because metadata-service is preferred
10:02 DEBUG [databricks.sdk] Ignoring basic auth, because metadata-service is preferred
10:02 DEBUG [databricks.sdk] Attempting to configure auth: metadata-service
10:02 INFO [databricks.sdk] Using Databricks Metadata Service authentication
[gw9] linux -- Python 3.10.13 /home/runner/work/lsql/lsql/.venv/bin/python
10:02 DEBUG [databricks.sdk] Loaded from environment
10:02 DEBUG [databricks.sdk] Ignoring pat auth, because metadata-service is preferred
10:02 DEBUG [databricks.sdk] Ignoring basic auth, because metadata-service is preferred
10:02 DEBUG [databricks.sdk] Attempting to configure auth: metadata-service
10:02 INFO [databricks.sdk] Using Databricks Metadata Service authentication
10:02 DEBUG [databricks.labs.lsql.backends] [api][execute] CREATE TABLE IF NOT EXISTS hive_metastore.default.foo (first STRING NOT NULL, second BOOLEAN NOT... (18 more bytes)
10:02 DEBUG [databricks.labs.lsql.core] Executing SQL statement: CREATE TABLE IF NOT EXISTS hive_metastore.default.foo (first STRING NOT NULL, second BOOLEAN NOT NULL) USING DELTA
10:02 DEBUG [databricks.sdk] POST /api/2.0/sql/statements/
> {
>   "format": "JSON_ARRAY",
>   "statement": "CREATE TABLE IF NOT EXISTS hive_metastore.default.foo (first STRING NOT NULL, second BOOLEAN NOT... (18 more bytes)",
>   "warehouse_id": "TEST_DEFAULT_WAREHOUSE_ID"
> }
< 200 OK
< {
<   "statement_id": "01eeecea-5977-1088-9587-d95375e923b1",
<   "status": {
<     "error": {
<       "error_code": "BAD_REQUEST",
<       "message": "[INSUFFICIENT_PERMISSIONS] Insufficient privileges:\nUser does not have permission CREATE,USAGE o... (21 more bytes)"
<     },
<     "state": "FAILED"
<   }
< }
10:02 DEBUG [databricks.sdk] Loaded from environment
10:02 DEBUG [databricks.sdk] Ignoring pat auth, because metadata-service is preferred
10:02 DEBUG [databricks.sdk] Ignoring basic auth, because metadata-service is preferred
10:02 DEBUG [databricks.sdk] Attempting to configure auth: metadata-service
10:02 INFO [databricks.sdk] Using Databricks Metadata Service authentication
10:02 DEBUG [databricks.labs.lsql.backends] [api][execute] CREATE TABLE IF NOT EXISTS hive_metastore.default.foo (first STRING NOT NULL, second BOOLEAN NOT... (18 more bytes)
10:02 DEBUG [databricks.labs.lsql.core] Executing SQL statement: CREATE TABLE IF NOT EXISTS hive_metastore.default.foo (first STRING NOT NULL, second BOOLEAN NOT NULL) USING DELTA
10:02 DEBUG [databricks.sdk] POST /api/2.0/sql/statements/
> {
>   "format": "JSON_ARRAY",
>   "statement": "CREATE TABLE IF NOT EXISTS hive_metastore.default.foo (first STRING NOT NULL, second BOOLEAN NOT... (18 more bytes)",
>   "warehouse_id": "TEST_DEFAULT_WAREHOUSE_ID"
> }
< 200 OK
< {
<   "statement_id": "01eeecea-5977-1088-9587-d95375e923b1",
<   "status": {
<     "error": {
<       "error_code": "BAD_REQUEST",
<       "message": "[INSUFFICIENT_PERMISSIONS] Insufficient privileges:\nUser does not have permission CREATE,USAGE o... (21 more bytes)"
<     },
<     "state": "FAILED"
<   }
< }
[gw9] linux -- Python 3.10.13 /home/runner/work/lsql/lsql/.venv/bin/python

Running from acceptance #48

nfx
nfx approved these changes Mar 28, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx merged commit d7698cf into main Mar 30, 2024
@nfx nfx deleted the fix_bad_test branch March 30, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nfx nfx nfx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@william-conti @nfx