Move create_dashboard mehod to DashboardMetadata#216
Merged
Conversation
JCZuurmond
commented
Jul 11, 2024
|
|
||
| def as_lakeview(self) -> Dashboard: | ||
| """Create a lakeview dashboard from the dashboard metadata.""" | ||
| datasets = self._get_datasets() |
Contributor
Author
There was a problem hiding this comment.
@nfx : My intuition is to remove the validate now as it is a side effect of as_lakeview and should be called by the user before as_lakeview. We also do not validate in the as_dict
JCZuurmond
commented
Jul 11, 2024
| database_to_replace : str | None (default: None) | ||
| The database to replace, if None, all databases are replaced | ||
|
|
||
| Source : |
Contributor
Author
There was a problem hiding this comment.
Was not in the right place anymore
|
✅ 35/35 passed, 2 skipped, 9m40s total Running from acceptance #304 |
JCZuurmond
commented
Jul 11, 2024
| assert tile.position.y == 8 | ||
|
|
||
|
|
||
| def test_dashboards_saves_sql_files_to_folder(tmp_path): |
Contributor
Author
There was a problem hiding this comment.
Moved the save_to_folder tests down to keep the test order somewhat consistent
JCZuurmond
commented
Jul 11, 2024
| ws.assert_not_called() | ||
|
|
||
|
|
||
| def test_dashboards_creates_dashboard_with_id_collisions_raises_value_error(tmp_path): |
Contributor
Author
There was a problem hiding this comment.
Removed as validate is removed from as_lakeview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #215