Allow overriding lower level Lakeview settings#195
Merged
JCZuurmond merged 21 commits intofeat/dashboard-as-code-for-ucxfrom Jun 27, 2024
Merged
Allow overriding lower level Lakeview settings#195JCZuurmond merged 21 commits intofeat/dashboard-as-code-for-ucxfrom
JCZuurmond merged 21 commits intofeat/dashboard-as-code-for-ucxfrom
Conversation
|
✅ 34/34 passed, 7 flaky, 2 skipped, 26m12s total Flaky tests:
Running from acceptance #242 |
nfx
reviewed
Jun 25, 2024
tests/unit/test_dashboards.py
Outdated
| ws.assert_not_called() | ||
|
|
||
|
|
||
| def test_dashboards_overwrites_with_overrides(tmp_path): |
Collaborator
There was a problem hiding this comment.
add a test how it will look like in dashboard.yml.
Contributor
Author
There was a problem hiding this comment.
First need #198 to parse tile metadata from dashboard.yml
Contributor
Author
There was a problem hiding this comment.
See test_dashboards_overrides_show_empty_title_in_dashboard_yml
JCZuurmond
force-pushed
the
feat/add-overrides
branch
from
4abab94 to
66e7366
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #191