Skip to content

Add multi select filter(s)#181

Merged
nfx merged 41 commits intofeat/dashboard-as-code-for-ucxfrom
feat/add-multi-select-filter-2
Jun 21, 2024
Merged

Add multi select filter(s)#181
nfx merged 41 commits intofeat/dashboard-as-code-for-ucxfrom
feat/add-multi-select-filter-2

Conversation

@JCZuurmond
Copy link
Copy Markdown
Contributor

@JCZuurmond JCZuurmond commented Jun 21, 2024

Resolves #169
Stacked on #150

See below the widgets with different number of filters and sizes:
Screenshot 2024-06-21 at 10 10 58
Screenshot 2024-06-21 at 10 08 24
Screenshot 2024-06-21 at 10 08 43
Screenshot 2024-06-21 at 10 09 13

@JCZuurmond JCZuurmond requested a review from nfx June 21, 2024 08:11
@JCZuurmond JCZuurmond self-assigned this Jun 21, 2024
@JCZuurmond JCZuurmond changed the base branch from main to feat/dashboard-as-code-for-ucx June 21, 2024 08:12
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 21, 2024

✅ 33/33 passed, 3 flaky, 2 skipped, 8m30s total

Flaky tests:

  • 🤪 test_dashboard_deploys_dashboard_with_table (21.479s)
  • 🤪 test_dashboards_deploys_dashboard_with_order_overwrite (22.267s)
  • 🤪 test_dashboard_deploys_dashboard_with_display_name (27.567s)

Running from acceptance #222

@JCZuurmond JCZuurmond force-pushed the feat/add-multi-select-filter-2 branch from 817a34b to ffb3307 Compare June 21, 2024 10:53
Copy link
Copy Markdown
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@nfx nfx merged commit aa2f325 into feat/dashboard-as-code-for-ucx Jun 21, 2024
@nfx nfx deleted the feat/add-multi-select-filter-2 branch June 21, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Filter dashboard widgets using multiple select

2 participants