Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: databrickslabs/lsql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.5.0
Choose a base ref
...
head repository: databrickslabs/lsql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.6.0
Choose a head ref
  • 8 commits
  • 8 files changed
  • 2 contributors

Commits on Jul 9, 2024

  1. Improve object oriented dashboard-as-code implementation (#208)

    Covers the outstanding comments in #201
    JCZuurmond authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    5b288fc View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Clean a bit of code (#209)

    Cleaning from #208
    JCZuurmond authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    4d6668f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e36702a View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Extend replace database in query (#210)

    Improve the database replacement in query by:
    - Making it part of the `DashboardMetadata` class
    - Allow specifying which database to replace
    - Support replacing catalog
    - Allow specifying which catalog to replace
    
    See
    https://github.com/databrickslabs/ucx/pull/1920/files/fae429e4d73eceebd7259c9bcaa390e6c7aa4395#r1670960522
    
    Partially resolves #212
    JCZuurmond authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    46875e7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ae37e6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a2323f8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f86d823 View commit details
    Browse the repository at this point in the history
  5. Release v0.6.0 (#217)

    * Added method to dashboards to get dashboard url
    ([#211](#211)). In this
    release, we have added a new method `get_url` to the
    `lakeview_dashboards` object in the `laksedashboard` library. This
    method utilizes the Databricks SDK to retrieve the dashboard URL,
    simplifying the code and making it more maintainable. Previously, the
    dashboard URL was constructed by concatenating the host and dashboard
    ID, but this new method ensures that the URL is obtained correctly, even
    if the format changes in the future. Additionally, a new unit test has
    been added for a method that gets the dashboard URL using the workspace
    client. This new functionality allows users to easily retrieve the URL
    for a dashboard using its ID and the workspace client.
    * Extend replace database in query
    ([#210](#210)). This commit
    extends the database replacement functionality in the
    `DashboardMetadata` class, allowing users to specify which database and
    catalog to replace. The enhancement includes support for catalog
    replacement and a new `replace_database` method in the
    `DashboardMetadata` class, which replaces the catalog and/or database in
    the query based on provided parameters. These changes enhance the
    flexibility and customization of the database replacement feature in
    queries, making it easier for users to control how their data is
    displayed in the dashboard. The `create_dashboard` function has also
    been updated to use the new method for replacing the database and
    catalog. Additionally, the `TileMetadata` update method has been
    replaced with a new merge method, and the `QueryTile` and `Tile` classes
    have new properties and methods for handling content, width, height, and
    position. The commit also includes several unit tests to ensure the new
    functionality works as expected.
    * Improve object oriented dashboard-as-code implementation
    ([#208](#208)). In this
    release, the object-oriented implementation of the dashboard-as-code
    feature has been significantly improved, addressing previous pull
    request comments
    ([#201](#201)). The
    `TileMetadata` dataclass now includes methods for updating and comparing
    tile metadata, and the `DashboardMetadata` class has been removed and
    its functionality incorporated into the `Dashboards` class. The
    `Dashboards` class now generates tiles, datasets, and layouts for
    dashboards using the provided `query_transformer`. The code's
    readability and maintainability have been further enhanced by replacing
    the use of the `copy` module with `dataclasses.replace` for creating
    object copies. Additionally, updates have been made to the unit tests
    for dashboard functionality in the project, with new methods and
    attributes added to check for valid dashboard metadata and handle
    duplicate query or widget IDs, as well as to specify the order in which
    tiles and widgets should be displayed in the dashboard.
    nfx authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    2c062b2 View commit details
    Browse the repository at this point in the history
Loading