Conversation
|
✅ 40/40 passed, 2 skipped, 1m44s total Running from acceptance #239 |
|
This PR breaks backwards compatibility for databrickslabs/ucx downstream. See build logs for more details. Running from downstreams #202 |
|
This PR breaks backwards compatibility for databrickslabs/lsql downstream. See build logs for more details. Running from downstreams #202 |
FastLee
force-pushed
the
fix/client_config_override_169
branch
from
e0b963c to
887b797
Compare
nfx
requested changes
Nov 14, 2024
| get_type_hints, | ||
| runtime_checkable, | ||
| ) | ||
| from unittest.mock import create_autospec |
Collaborator
There was a problem hiding this comment.
you cannot include unit-testing dependencies in the production code.
| if not inst: | ||
| return None, False | ||
| return inst.as_dict(), True | ||
| current_client_config = self._ws.config.as_dict() |
Collaborator
There was a problem hiding this comment.
refactor self._ws.config.as_dict() to a private cached property, which you override in MockInstallation to avoid unittest dependency that does not belong to this module.
nfx
changed the title
nfx
added a commit
that referenced
this pull request
Nov 14, 2024
* Fixed issue when Databricks SDK config objects were overridden for installation config files ([#170](#170)). This commit addresses an issue where Databricks SDK config objects were being overridden during installation config files creation, which has been resolved by modifying the `_marshal` method in the `installation` class to handle `databricks.sdk.core.Config` instances more carefully, and by introducing a new helper function `get_databricks_sdk_config` in the `paths.py` file, which retrieves the Databricks SDK configuration and improves the reliability and robustness of the SDK configuration. This fixes bug [#169](#169) and ensures that the SDK configuration is not accidentally modified during the installation process, preventing unexpected behavior and errors. The changes are isolated to the `paths.py` file and do not affect other parts of the codebase.
Merged
nfx
added a commit
that referenced
this pull request
Nov 14, 2024
* Fixed issue when Databricks SDK config objects were overridden for installation config files ([#170](#170)). This commit addresses an issue where Databricks SDK config objects were being overridden during installation config files creation, which has been resolved by modifying the `_marshal` method in the `installation` class to handle `databricks.sdk.core.Config` instances more carefully, and by introducing a new helper function `get_databricks_sdk_config` in the `paths.py` file, which retrieves the Databricks SDK configuration and improves the reliability and robustness of the SDK configuration. This fixes bug [#169](#169) and ensures that the SDK configuration is not accidentally modified during the installation process, preventing unexpected behavior and errors. The changes are isolated to the `paths.py` file and do not affect other parts of the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #169