Skip to content

Fix crash when error happens during reading databricks_job#5110

Merged
alexott merged 3 commits intomainfrom
fix/crash-on-error-job-read
Oct 21, 2025
Merged

Fix crash when error happens during reading databricks_job#5110
alexott merged 3 commits intomainfrom
fix/crash-on-error-job-read

Conversation

@alexott
Copy link
Copy Markdown
Contributor

@alexott alexott commented Oct 17, 2025

Changes

The crash occurred when reading a job and backend returned an error, so the job became nil, but we still tried to access fields inside the struct, instead of returning the error immediately.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework
  • has entry in NEXT_CHANGELOG.md file

The crash occurred when reading a job and backend returned an error, so the `job` became
`nil`, but we still tried to access fields inside the struct, instead of returning the
error immediately.
@alexott alexott requested review from a team as code owners October 17, 2025 11:41
@alexott alexott requested review from mgyucht and removed request for a team October 17, 2025 11:41
@alexott alexott temporarily deployed to test-trigger-is October 17, 2025 11:41 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is October 17, 2025 11:41 — with GitHub Actions Inactive
Comment thread jobs/jobs_api_go_sdk.go
@alexott alexott temporarily deployed to test-trigger-is October 17, 2025 15:15 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is October 17, 2025 15:15 — with GitHub Actions Inactive
@alexott alexott enabled auto-merge October 17, 2025 15:16
@alexott alexott temporarily deployed to test-trigger-is October 20, 2025 13:41 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 5110
  • Commit SHA: 1a9a9fe8888132c3b4406cf3afb052dc412c8ec0

Checks will be approved automatically on success.

@alexott alexott temporarily deployed to test-trigger-is October 20, 2025 13:42 — with GitHub Actions Inactive
@alexott alexott added this pull request to the merge queue Oct 21, 2025
Merged via the queue into main with commit 8d94bd1 Oct 21, 2025
12 checks passed
@alexott alexott deleted the fix/crash-on-error-job-read branch October 21, 2025 07:17
deco-sdk-tagging bot added a commit that referenced this pull request Oct 21, 2025
## Release v1.94.0

### Bug Fixes

* Fix crash when error happens during reading `databricks_job` ([#5110](#5110))
* Fix `ADMIN` assignment in `databricks_permission_assignment` resource ([#5109](#5109))

### Documentation

* Document `table_update` trigger in `databricks_job` resource ([#5107](#5107))
* Document new attributes in `databricks_app` resource and data sources ([#5108](#5108))
* Document `git_email` in `databricks_git_credential` resource ([#5099](#5099))
* Update `CONTRIBUTING` guidelines for migrating resources to plugin framework ([#5121](#5121))

### Internal Changes

* Add provider_config support for plugin framework ([#5104](#5104))
* Refactor `catalog_test.go` to use internal plan checks ([#5112](#5112)).
andrewnester added a commit to databricks/cli that referenced this pull request Oct 22, 2025
## Changes
Upgrade TF provider to 1.94.0

## Why
Includes a fix for a crash when an error happens during reading
databricks_job
(databricks/terraform-provider-databricks#5110)

Fixes #3783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants