[Fix] Tolerate databricks_permissions resources for SQL warehouses with /warehouses/... IDs#4158
Merged
[Fix] Tolerate databricks_permissions resources for SQL warehouses with /warehouses/... IDs#4158
databricks_permissions resources for SQL warehouses with /warehouses/... IDs#4158Conversation
mgyucht
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Test Details: go/deco-tests/11518956399 |
mgyucht
commented
Oct 25, 2024
Comment on lines
+620
to
+625
| tags { | ||
| custom_tags { | ||
| key = "Owner" | ||
| value = "eng-dev-ecosystem-team_at_databricks.com" | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
The test wasn't running locally before I added this. I'm not sure how it ran before. Our account requires the Owner tag, so this allows the test to run.
rauchy
approved these changes
Oct 25, 2024
alexott
approved these changes
Oct 28, 2024
mgyucht
added a commit
that referenced
this pull request
Oct 28, 2024
### Bug Fixes * Recreate missing system schema ([#4068](#4068)). * Tolerate `databricks_permissions` resources for SQL warehouses with `/warehouses/...` IDs ([#4158](#4158)). ### Documentation * Fix `databricks_grant` regarding metastore_id description ([#4164](#4164)). ### Internal Changes * Automatically trigger integration tests on PR ([#4149](#4149)). ### Exporter * **Breaking change** Use new query and alert resources instead of legacy resources ([#4150](#4150)). * Improve exporting of `databricks_pipeline` resources ([#4142](#4142)). * Improving reliability of `Emit` function ([#4163](#4163)).
mgyucht
added a commit
that referenced
this pull request
Oct 28, 2024
### Bug Fixes * Recreate missing system schema ([#4068](#4068)). * Tolerate `databricks_permissions` resources for SQL warehouses with `/warehouses/...` IDs ([#4158](#4158)). ### Documentation * Fix `databricks_grant` regarding metastore_id description ([#4164](#4164)). ### Internal Changes * Automatically trigger integration tests on PR ([#4149](#4149)). ### Exporter * **Breaking change** Use new query and alert resources instead of legacy resources ([#4150](#4150)). * Improve exporting of `databricks_pipeline` resources ([#4142](#4142)). * Improving reliability of `Emit` function ([#4163](#4163)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
### Bug Fixes * Recreate missing system schema ([#4068](#4068)). * Tolerate `databricks_permissions` resources for SQL warehouses with `/warehouses/...` IDs ([#4158](#4158)). ### Documentation * Fix `databricks_grant` regarding metastore_id description ([#4164](#4164)). ### Internal Changes * Automatically trigger integration tests on PR ([#4149](#4149)). ### Exporter * **Breaking change** Use new query and alert resources instead of legacy resources ([#4150](#4150)). * Improve exporting of `databricks_pipeline` resources ([#4142](#4142)). * Improving reliability of `Emit` function ([#4163](#4163)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
#4143 reported a regression to the
databricks_permissionsresource caused by #3956. Normally, the ID for this resource when configured for a SQL warehouse is/sql/warehouses/<ID>. However, it seems like at some point in the past, some users may have had an ID of/warehouses/<ID>. It's possible that importing this resource worked like this: when calling the permissions REST API, whether using object typesql/warehousesorwarehouses, the API returns permissions for the same resources:This PR modifies the SQL warehouse configuration for
databricks_permissionsto be chosen for instances with an ID of the form/warehouses/....Tests
The additional integration test ensures that a resource can be imported with the
/warehouses/<ID>format.