Skip to content

[DOC] Squash job and task level sections to unified sections#3536

Merged
mgyucht merged 4 commits intodatabricks:mainfrom
landlord-matt:patch-6
May 3, 2024
Merged

[DOC] Squash job and task level sections to unified sections#3536
mgyucht merged 4 commits intodatabricks:mainfrom
landlord-matt:patch-6

Conversation

@landlord-matt
Copy link
Copy Markdown
Contributor

@landlord-matt landlord-matt commented May 2, 2024

Changes

Merge the separated job and task level sections of email_notifications and notification_settings into two unified sections. This limits copy pasting and makes it easier to navigate

Also move parameter section about notification sections

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@landlord-matt landlord-matt requested review from a team as code owners May 2, 2024 15:33
@landlord-matt landlord-matt requested review from tanmay-db and removed request for a team May 2, 2024 15:33
@landlord-matt landlord-matt mentioned this pull request May 3, 2024
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.70%. Comparing base (40141ba) to head (241686c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3536   +/-   ##
=======================================
  Coverage   82.70%   82.70%           
=======================================
  Files         183      183           
  Lines       18829    18829           
=======================================
  Hits        15573    15573           
  Misses       2340     2340           
  Partials      916      916           

@mgyucht mgyucht added this pull request to the merge queue May 3, 2024
Merged via the queue into databricks:main with commit 3642a1f May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants