Conversation
tanmay-db
requested review from
hectorcast-db
and removed request for
a team and
hectorcast-db
alexott
approved these changes
May 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3530 +/- ##
=======================================
Coverage ? 82.70%
=======================================
Files ? 184
Lines ? 18745
Branches ? 0
=======================================
Hits ? 15503
Misses ? 2342
Partials ? 900 |
3 tasks
mgyucht
added a commit
that referenced
this pull request
May 3, 2024
### New Features and Improvements * Allow changes to `display_name` for `databricks_service_principal` ([#3523](#3523)). * Modify `databricks_repo` to support Git folders in the workspace ([#3447](#3447)). * Retry requests in the Databricks Go SDK until context timeout ([#3537](#3537)). * Set ForceSendFields for boolean/integer values explicitly set to false/0 ([#3385](#3385)). ### Bug fixes * Added `ConflictsWith` to legacy tasks in `databricks_job` to avoid errors when job parameters are used ([#3500](#3500)). * Fixed spn secret permanent diff ([#3525](#3525)). * Introduced `common.NoClientData` helper function and use it in `databricks_aws_crossaccount_policy` data source to allow its use with workspace- or account-level providers ([#3508](#3508)). * Set `id` attribute of `databricks_metastore` data source ([#3503](#3503)). ### Documentation Changes * Added documentation for compute options for tasks in `databricks_job` resource ([#3504](#3504)). * Added warning about depends_on order ([#3489](#3489)). * Fixed various doc typos ([#3512](#3512)). * Fixed `databricks_current_metastore` data source names in docs examples ([#3515](#3515)). * Improved Job documentation structure ([#3511](#3511)). * Removed confusing mention of cloud types for `databricks_clusters` and `databricks_sql_warehouses` data sources ([#3518](#3518)). ### Exporter * Added UC support for DLT pipelines ([#3494](#3494)). * Ignored instance pools with the empty name ([#3522](#3522)). ### Internal Changes * Added DATABRICKS_USER_AGENT_EXTRA ([#3520](#3520)). * Adjusted list of supported platforms in `godownloader-databricks-provider.sh` ([#3527](#3527)). * Switched to Go SDK for `databricks_directory` resource and data source ([#3509](#3509)). * Fixed codecov for repository ([#3530](#3530)). Dependency updates: * Bump databricks-sdk-go to v0.40.0 ([#3534](#3534)).
Merged
3 tasks
github-merge-queue bot
pushed a commit
to databricks/databricks-sdk-py
that referenced
this pull request
May 3, 2024
## Changes <!-- Summary of your changes that are easy to understand --> Same as: databricks/terraform-provider-databricks#3530 ## Tests <!-- How is this tested? Please see the checklist below and also describe any other relevant tests --> CI: ``` info - 2024-05-03 09:57:07,135 -- > /home/runner/work/databricks-sdk-py/databricks-sdk-py/coverage.xml info - 2024-05-03 09:57:07,425 -- Your upload is now processing. When finished, results will be available at: https://app.codecov.io/github/databricks/databricks-sdk-py/commit/67211d374104c143c07a62ebd2f4ab3f61f613a2 info - 2024-05-03 09:57:07,600 -- Process Upload complete ``` - [ ] `make test` run locally - [ ] `make fmt` applied - [ ] relevant integration tests applied
github-merge-queue bot
pushed a commit
to databricks/databricks-sdk-go
that referenced
this pull request
May 3, 2024
## Changes <!-- Summary of your changes that are easy to understand --> Same as databricks/terraform-provider-databricks#3530 ## Tests <!-- How is this tested? Please see the checklist below and also describe any other relevant tests --> CI: ````` info - 2024-05-03 10:00:47,486 -- Found 1 coverage files to report info - 2024-05-03 10:00:47,486 -- > /home/runner/work/databricks-sdk-go/databricks-sdk-go/coverage.txt info - 2024-05-03 10:00:48,261 -- Your upload is now processing. When finished, results will be available at: https://app.codecov.io/github/databricks/databricks-sdk-go/commit/fe2a4e7a993c5183e6324e324fa4542dc7b60c9d info - 2024-05-03 10:00:48,5[47](https://github.com/databricks/databricks-sdk-go/actions/runs/8937140473/job/24549255623?pr=909#step:7:48) -- Process Upload complete ````` - [ ] `make test` passing - [ ] `make fmt` applied - [ ] relevant integration tests applied
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 3, 2024
* Release v1.42.0 ### New Features and Improvements * Allow changes to `display_name` for `databricks_service_principal` ([#3523](#3523)). * Modify `databricks_repo` to support Git folders in the workspace ([#3447](#3447)). * Retry requests in the Databricks Go SDK until context timeout ([#3537](#3537)). * Set ForceSendFields for boolean/integer values explicitly set to false/0 ([#3385](#3385)). ### Bug fixes * Added `ConflictsWith` to legacy tasks in `databricks_job` to avoid errors when job parameters are used ([#3500](#3500)). * Fixed spn secret permanent diff ([#3525](#3525)). * Introduced `common.NoClientData` helper function and use it in `databricks_aws_crossaccount_policy` data source to allow its use with workspace- or account-level providers ([#3508](#3508)). * Set `id` attribute of `databricks_metastore` data source ([#3503](#3503)). ### Documentation Changes * Added documentation for compute options for tasks in `databricks_job` resource ([#3504](#3504)). * Added warning about depends_on order ([#3489](#3489)). * Fixed various doc typos ([#3512](#3512)). * Fixed `databricks_current_metastore` data source names in docs examples ([#3515](#3515)). * Improved Job documentation structure ([#3511](#3511)). * Removed confusing mention of cloud types for `databricks_clusters` and `databricks_sql_warehouses` data sources ([#3518](#3518)). ### Exporter * Added UC support for DLT pipelines ([#3494](#3494)). * Ignored instance pools with the empty name ([#3522](#3522)). ### Internal Changes * Added DATABRICKS_USER_AGENT_EXTRA ([#3520](#3520)). * Adjusted list of supported platforms in `godownloader-databricks-provider.sh` ([#3527](#3527)). * Switched to Go SDK for `databricks_directory` resource and data source ([#3509](#3509)). * Fixed codecov for repository ([#3530](#3530)). Dependency updates: * Bump databricks-sdk-go to v0.40.0 ([#3534](#3534)). * Changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
We are using 5 year old action of codecov and it is leading to throttling, also tried with v3 which again lead to throttle. Updated to use v4 which requires CODECOV_TOKEN (uploaded it to action secrets).
Tests
Codecov upload passes on PR using the token: https://github.com/databricks/terraform-provider-databricks/actions/runs/8913166757/job/24478449974?pr=3530
make testrun locallydocs/folderinternal/acceptance