Migrate client to github.com/databricks/databricks-sdk-go#1848
Merged
Conversation
Contributor
Author
|
current status:
|
Contributor
Author
|
current status:
|
Contributor
Author
|
current status (with go sdk v0.3.1 upstream)
|
nfx
added a commit
to databricks/databricks-sdk-go
that referenced
this pull request
Feb 17, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1848 +/- ##
==========================================
- Coverage 90.33% 89.51% -0.82%
==========================================
Files 146 140 -6
Lines 11911 11038 -873
==========================================
- Hits 10760 9881 -879
- Misses 743 767 +24
+ Partials 408 390 -18
|
Contributor
|
Need to fix test although |
pietern
reviewed
Feb 20, 2023
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
This removes a few acceptance tests that look legit, most notably the storage ones.
The change in error message on invalid authentication is not optimal. The original message hinted at the provider configuration where the new one doesn't. I think it's worth intercepting and wrapping it to stick to the original message.
nfx
changed the title
github.com/databricks/databricks-sdk-go
This was referenced Feb 20, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR starts migration to https://github.com/databricks/databricks-sdk-go by replacing the configuration and HTTP client layer with the one defined in Go SDK. SDK inherits a lot of original terraform client implementations.