This repository was archived by the owner on Nov 19, 2024. It is now read-only.
[PLAT-26620] Log multiple instances of devbox to sentry #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielrussoc
requested review from
iuliand-db,
lihaoyi-databricks and
margaret-databricks
gabrielrussoc
commented
Jan 29, 2021
| } | ||
|
|
||
| def sentryCapture(e: Throwable): Unit = { | ||
| io.sentry.Sentry.getContext().addTag("whoami", System.getProperty("user.name")) |
Contributor
Author
There was a problem hiding this comment.
I tried to reuse this with the Event but for some reason it didn't work. So I ended up adding it on the EventBuilder as well.
iuliand-db
suggested changes
Feb 1, 2021
launcher/src/Instance.scala
Outdated
| new EventBuilder() | ||
| .withMessage("Multiple devbox instances running") | ||
| .withLevel(Level.WARNING) | ||
| .withTag("whoami", System.getProperty("user.name")) |
Contributor
There was a problem hiding this comment.
Let's add some details about the instances themselves, perhaps creation date and state? We might be able to guess some patterns about the conditions under which we get to this state.
gabrielrussoc
force-pushed
the
log-multiple-devbox-sentry
branch
from
be59403 to
f02307d
Compare
Contributor
Author
|
Added info about the instances, example: |
iuliand-db
approved these changes
Feb 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's log an entry to sentry to get a better understanding of how common this error is.
https://sentry.dev.databricks.com/sentry/devbox/issues/93360/events/