Conversation
benc-db
requested review from
andrefurlan-db,
rcypher-databricks and
susodapop
as code owners
rcypher-databricks
previously approved these changes
Nov 8, 2023
benc-db
dismissed stale reviews from susodapop and rcypher-databricks
via
881579b
mikealfare
reviewed
Nov 8, 2023
Contributor
mikealfare
left a comment
mikealfare
left a comment
There was a problem hiding this comment.
I made some comments of a few things to discuss. I'll look through the full project, specifically for the Adapter and Relation classes, to see if I find anything else.
|
|
||
| def get_catalog( | ||
| self, manifest: Manifest, selected_nodes: Optional[Set] = None | ||
| self, manifest: Manifest, selected_nodes: Optional[Set[Any]] = None |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
rcypher-databricks
approved these changes
Nov 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes
a.) change to get_catalog to account for changes that dbt made between 1.7.0rc1 and 1.7.0
b.) a fix for a PR I merged earlier that removed casts from seeding. Turns out that with hive and parquet, the cast is necessary for numeric types; the tests passed initially because the old version of the copy_into tests didn't use seeds, and nowhere else in our project do we test parquet and seeds.
c.) a modification to our external location integration variable because something has changed (I think in the dbr) so that its extra sensitive to running in the top level of a container
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.